Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-09 07:34:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

[RUF] Add rule to detect empty literal in deque call (RUF025) (#15104)

Browse Source
This commit is contained in:
w0nder1ng
2025-01-03 05:57:13 -05:00
committed by GitHub
parent 0dbfa8d0e0
commit 0837cdd931
9 changed files with 318 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/ruff_python_ast/src/nodes.rs
View File

@@ -3774,14 +3774,14 @@ pub struct Arguments {
}
/// An entry in the argument list of a function call.
#[derive(Clone, Debug, PartialEq)]
#[derive(Copy, Clone, Debug, PartialEq)]
pub enum ArgOrKeyword<'a> {
Arg(&'a Expr),
Keyword(&'a Keyword),
}
impl<'a> ArgOrKeyword<'a> {
pub const fn value(&self) -> &'a Expr {
pub const fn value(self) -> &'a Expr {
match self {
ArgOrKeyword::Arg(argument) => argument,
ArgOrKeyword::Keyword(keyword) => &keyword.value,
@@ -3841,9 +3841,7 @@ impl Arguments {
/// argument exists. Used to retrieve argument values that can be provided _either_ as keyword or
/// positional arguments.
pub fn find_argument_value(&self, name: &str, position: usize) -> Option<&Expr> {
self.find_keyword(name)
.map(|keyword| &keyword.value)
.or_else(|| self.find_positional(position))
self.find_argument(name, position).map(ArgOrKeyword::value)
}
/// Return the the argument with the given name or at the given position, or `None` if no such