Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-22 14:00:51 -05:00
Code Issues Packages Projects Releases Wiki Activity

[ty] Fix assignability checks for invariant generics parameterized by gradual types (#18138)

Browse Source
This commit is contained in:
Alex Waygood
2025-05-16 13:37:07 -04:00
committed by GitHub
parent 28fb802467
commit 0adbb3d600
2 changed files with 61 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
crates/ty_python_semantic/src/types/generics.rs
View File

@@ -457,10 +457,13 @@ impl<'db> Specialization<'db> {
// corresponding typevar:
// - covariant: verify that self_type <: other_type
// - contravariant: verify that other_type <: self_type
// - invariant: verify that self_type == other_type
// - invariant: verify that self_type <: other_type AND other_type <: self_type
// - bivariant: skip, can't make assignability false
let compatible = match typevar.variance(db) {
TypeVarVariance::Invariant => self_type.is_gradual_equivalent_to(db, *other_type),
TypeVarVariance::Invariant => {
self_type.is_assignable_to(db, *other_type)
&& other_type.is_assignable_to(db, *self_type)
}
TypeVarVariance::Covariant => self_type.is_assignable_to(db, *other_type),
TypeVarVariance::Contravariant => other_type.is_assignable_to(db, *self_type),
TypeVarVariance::Bivariant => true,