diff --git a/crates/ruff/resources/test/fixtures/flake8_pyi/PYI050.py b/crates/ruff/resources/test/fixtures/flake8_pyi/PYI050.py index fd2599735b..042fe887ec 100644 --- a/crates/ruff/resources/test/fixtures/flake8_pyi/PYI050.py +++ b/crates/ruff/resources/test/fixtures/flake8_pyi/PYI050.py @@ -1,4 +1,5 @@ from typing import NoReturn, Never +import typing_extensions def foo(arg): @@ -10,15 +11,21 @@ def foo_int(arg: int): def foo_no_return(arg: NoReturn): - ... # Error: PYI050 + ... + + +def foo_no_return_typing_extensions( + arg: typing_extensions.NoReturn, +): + ... def foo_no_return_kwarg(arg: int, *, arg2: NoReturn): - ... # Error: PYI050 + ... def foo_no_return_pos_only(arg: int, /, arg2: NoReturn): - ... # Error: PYI050 + ... def foo_never(arg: Never): diff --git a/crates/ruff/src/rules/flake8_pyi/snapshots/ruff__rules__flake8_pyi__tests__PYI050_PYI050.pyi.snap b/crates/ruff/src/rules/flake8_pyi/snapshots/ruff__rules__flake8_pyi__tests__PYI050_PYI050.pyi.snap index 6c9465a71a..5b051189e1 100644 --- a/crates/ruff/src/rules/flake8_pyi/snapshots/ruff__rules__flake8_pyi__tests__PYI050_PYI050.pyi.snap +++ b/crates/ruff/src/rules/flake8_pyi/snapshots/ruff__rules__flake8_pyi__tests__PYI050_PYI050.pyi.snap @@ -7,27 +7,27 @@ PYI050.pyi:6:24: PYI050 Prefer typing_extensions.Never over NoReturn for argumen 7 | def foo_int(arg: int): ... 8 | def foo_no_return(arg: NoReturn): ... # Error: PYI050 | ^^^^^^^^ PYI050 - 9 | def foo_no_return_typing_extensions(arg: typing_extensions.NoReturn): ... # Error: PYI050 -10 | def foo_no_return_kwarg(arg: int, *, arg2: NoReturn): ... # Error: PYI050 + 9 | def foo_no_return_typing_extensions( +10 | arg: typing_extensions.NoReturn, | -PYI050.pyi:8:44: PYI050 Prefer typing_extensions.Never over NoReturn for argument annotations. +PYI050.pyi:10:44: PYI050 Prefer typing_extensions.Never over NoReturn for argument annotations. | - 8 | def foo_no_return(arg: NoReturn): ... # Error: PYI050 - 9 | def foo_no_return_typing_extensions(arg: typing_extensions.NoReturn): ... # Error: PYI050 -10 | def foo_no_return_kwarg(arg: int, *, arg2: NoReturn): ... # Error: PYI050 +10 | arg: typing_extensions.NoReturn, +11 | ): ... # Error: PYI050 +12 | def foo_no_return_kwarg(arg: int, *, arg2: NoReturn): ... # Error: PYI050 | ^^^^^^^^ PYI050 -11 | def foo_no_return_pos_only(arg: int, /, arg2: NoReturn): ... # Error: PYI050 -12 | def foo_never(arg: Never): ... +13 | def foo_no_return_pos_only(arg: int, /, arg2: NoReturn): ... # Error: PYI050 +14 | def foo_never(arg: Never): ... | -PYI050.pyi:9:47: PYI050 Prefer typing_extensions.Never over NoReturn for argument annotations. +PYI050.pyi:11:47: PYI050 Prefer typing_extensions.Never over NoReturn for argument annotations. | - 9 | def foo_no_return_typing_extensions(arg: typing_extensions.NoReturn): ... # Error: PYI050 -10 | def foo_no_return_kwarg(arg: int, *, arg2: NoReturn): ... # Error: PYI050 -11 | def foo_no_return_pos_only(arg: int, /, arg2: NoReturn): ... # Error: PYI050 +11 | ): ... # Error: PYI050 +12 | def foo_no_return_kwarg(arg: int, *, arg2: NoReturn): ... # Error: PYI050 +13 | def foo_no_return_pos_only(arg: int, /, arg2: NoReturn): ... # Error: PYI050 | ^^^^^^^^ PYI050 -12 | def foo_never(arg: Never): ... +14 | def foo_never(arg: Never): ... |