Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[`flake8-self`] Ignore `_name_` and `_value_` (#5663) 

## Summary

`Enum._name_` and `Enum._value_` are so named to prevent conflicts. See
<https://docs.python.org/3/library/enum.html#supported-sunder-names>.

## Test Plan

Tests for `ignore-names` already exist.
This commit is contained in:
monosans 2023-07-10 18:52:59 +00:00 committed by GitHub
parent b8a6ce43a2
commit 14f2158e5d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
crates/ruff/src/rules/flake8_self/settings.rs
View File

@ -4,9 +4,18 @@ use serde::{Deserialize, Serialize};
use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions}; use ruff_macros::{CacheKey, CombineOptions, ConfigurationOptions};
// By default, ignore the `namedtuple` methods and attributes, which are underscore-prefixed to // By default, ignore the `namedtuple` methods and attributes, as well as the
// prevent conflicts with field names. // _sunder_ names in Enum, which are underscore-prefixed to prevent conflicts
const IGNORE_NAMES: [&str; 5] = ["_make", "_asdict", "_replace", "_fields", "_field_defaults"]; // with field names.
const IGNORE_NAMES: [&str; 7] = [
"_make",
"_asdict",
"_replace",
"_fields",
"_field_defaults",
"_name_",
"_value_",
];
#[derive( #[derive(
Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions, Debug, PartialEq, Eq, Serialize, Deserialize, Default, ConfigurationOptions, CombineOptions,
@ -19,7 +28,7 @@ const IGNORE_NAMES: [&str; 5] = ["_make", "_asdict", "_replace", "_fields", "_fi
#[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))] #[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))]
pub struct Options { pub struct Options {
#[option( #[option(
default = r#"["_make", "_asdict", "_replace", "_fields", "_field_defaults"]"#, default = r#"["_make", "_asdict", "_replace", "_fields", "_field_defaults", "_name_", "_value_"]"#,
value_type = "list[str]", value_type = "list[str]",
example = r#" example = r#"
ignore-names = ["_new"] ignore-names = ["_new"]