From 16a350c7315e755c40cd78d882d06fc965b6d326 Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Sat, 18 Mar 2023 13:13:09 -0400 Subject: [PATCH] Reduce usage of ALL in ecosystem CI (#3590) --- scripts/check_ecosystem.py | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/scripts/check_ecosystem.py b/scripts/check_ecosystem.py index ccbf1d7629..e25bd073f2 100755 --- a/scripts/check_ecosystem.py +++ b/scripts/check_ecosystem.py @@ -29,7 +29,7 @@ class Repository(NamedTuple): org: str repo: str ref: str - select: str = "ALL" + select: str = "" ignore: str = "" exclude: str = "" @@ -58,13 +58,14 @@ class Repository(NamedTuple): REPOSITORIES = { - "zulip": Repository("zulip", "zulip", "main"), - "bokeh": Repository("bokeh", "bokeh", "branch-3.2"), + "airflow": Repository("apache", "airflow", "main", select="ALL"), + "bokeh": Repository("bokeh", "bokeh", "branch-3.2", select="ALL"), + "cibuildwheel": Repository("pypa", "cibuildwheel", "main"), + "disnake": Repository("DisnakeDev", "disnake", "main"), "scikit-build": Repository("scikit-build", "scikit-build", "main"), "scikit-build-core": Repository("scikit-build", "scikit-build-core", "main"), - "cibuildwheel": Repository("pypa", "cibuildwheel", "main"), - "airflow": Repository("apache", "airflow", "main"), "typeshed": Repository("python", "typeshed", "main", select="PYI"), + "zulip": Repository("zulip", "zulip", "main", select="ALL"), } SUMMARY_LINE_RE = re.compile(r"^(Found \d+ error.*)|(.*potentially fixable with.*)$") @@ -78,12 +79,14 @@ async def check( *, ruff: Path, path: Path, - select: str, + select: str = "", ignore: str = "", exclude: str = "", ) -> "Sequence[str]": """Run the given ruff binary against the specified path.""" - ruff_args = ["check", "--no-cache", "--exit-zero", "--select", select] + ruff_args = ["check", "--no-cache", "--exit-zero"] + if select: + ruff_args.extend(["--select", select]) if ignore: ruff_args.extend(["--ignore", ignore]) if exclude: