Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

red_knot_python_semantic: remove comment about `TypeCheckDiagnostic` 

I put this in its own commit in case all of the information removed here
was controversial. But it *looks* stale to me. At the very least,
`TypeCheckDiagnostic` no longer exists, so that would need to be fixed.
And it doesn't really make sense to me (at this point) to make
`Diagnostic` a Salsa struct, particularly since we are keen on using it
in Ruff (at some point).
This commit is contained in:
Andrew Gallant 2025-04-01 15:04:05 -04:00 committed by Andrew Gallant
parent c30e80a3f4
commit 185bcfef1a
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/red_knot_python_semantic/src/types/diagnostic.rs
View File

@ -895,12 +895,6 @@ declare_lint! {
} }
/// A collection of type check diagnostics. /// A collection of type check diagnostics.
///
/// The diagnostics are wrapped in an `Arc` because they need to be cloned multiple times
/// when going from `infer_expression` to `check_file`. We could consider
/// making [`TypeCheckDiagnostic`] a Salsa struct to have them Arena-allocated (once the Tables refactor is done).
/// Using Salsa struct does have the downside that it leaks the Salsa dependency into diagnostics and
/// each Salsa-struct comes with an overhead.
#[derive(Default, Eq, PartialEq)] #[derive(Default, Eq, PartialEq)]
pub struct TypeCheckDiagnostics { pub struct TypeCheckDiagnostics {
diagnostics: Vec<Diagnostic>, diagnostics: Vec<Diagnostic>,