Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use `Scope#has` in lieu of `Scope#get` (#5051) 

## Summary

These usages don't actually need the `BindingId`.
This commit is contained in:
Charlie Marsh 2023-06-13 11:59:53 -04:00 committed by GitHub
parent b0f89fa814
commit 19f972a305
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
crates/ruff_python_semantic/src/model.rs
View File

@ -405,7 +405,7 @@ impl<'a> SemanticModel<'a> {
if self if self
.scopes() .scopes()
.take(scope_index) .take(scope_index)
.all(|scope| scope.get(name).is_none()) .all(|scope| !scope.has(name))
{ {
return Some(ImportedName { return Some(ImportedName {
name: format!("{name}.{member}"), name: format!("{name}.{member}"),
@ -428,7 +428,7 @@ impl<'a> SemanticModel<'a> {
if self if self
.scopes() .scopes()
.take(scope_index) .take(scope_index)
.all(|scope| scope.get(name).is_none()) .all(|scope| !scope.has(name))
{ {
return Some(ImportedName { return Some(ImportedName {
name: (*name).to_string(), name: (*name).to_string(),
@ -449,7 +449,7 @@ impl<'a> SemanticModel<'a> {
if self if self
.scopes() .scopes()
.take(scope_index) .take(scope_index)
.all(|scope| scope.get(name).is_none()) .all(|scope| !scope.has(name))
{ {
return Some(ImportedName { return Some(ImportedName {
name: format!("{name}.{member}"), name: format!("{name}.{member}"),