Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid `.unwrap()` on cache access (#5229) 

## Summary

I haven't been able to determine why / when this is happening, but in
some cases, users are reporting that this `unwrap()` is causing a panic.
It's fine to just return `None` here and fallback to "No cache",
certainly better than panicking (while we figure out the edge case).

Closes #5225.

Closes #5228.
This commit is contained in:
Charlie Marsh 2023-06-20 19:01:21 -04:00 committed by GitHub
parent 4717d0779f
commit 1a2bd984f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/ruff_cli/src/commands/run.rs
View File

@ -107,9 +107,7 @@ pub(crate) fn run(
let settings = resolver.resolve_all(path, pyproject_config); let settings = resolver.resolve_all(path, pyproject_config);
let package_root = package.unwrap_or_else(|| path.parent().unwrap_or(path)); let package_root = package.unwrap_or_else(|| path.parent().unwrap_or(path));
let cache = caches let cache = caches.as_ref().and_then(|caches| caches.get(&package_root));
.as_ref()
.map(|caches| caches.get(&package_root).unwrap());
lint_path(path, package, settings, cache, noqa, autofix).map_err(|e| { lint_path(path, package, settings, cache, noqa, autofix).map_err(|e| {
(Some(path.to_owned()), { (Some(path.to_owned()), {