From 2125d0bb540607eaa32442eb205f36a674726759 Mon Sep 17 00:00:00 2001 From: Martin Fischer Date: Wed, 25 Jan 2023 06:13:22 +0100 Subject: [PATCH] refactor: Move #![forbid(unsafe_code)] attributes up What's forbidden is more important than which clippy lints are ignored and more important directives should come first. --- flake8_to_ruff/src/main.rs | 2 +- ruff_cli/src/lib.rs | 1 + ruff_cli/src/main.rs | 2 +- ruff_dev/src/main.rs | 2 +- ruff_macros/src/lib.rs | 2 +- src/lib.rs | 2 +- 6 files changed, 6 insertions(+), 5 deletions(-) diff --git a/flake8_to_ruff/src/main.rs b/flake8_to_ruff/src/main.rs index 447757abb6..e5dbcf2662 100644 --- a/flake8_to_ruff/src/main.rs +++ b/flake8_to_ruff/src/main.rs @@ -1,4 +1,5 @@ //! Utility to generate Ruff's `pyproject.toml` section from a Flake8 INI file. +#![forbid(unsafe_code)] #![allow( clippy::collapsible_else_if, clippy::collapsible_if, @@ -11,7 +12,6 @@ clippy::similar_names, clippy::too_many_lines )] -#![forbid(unsafe_code)] use std::path::PathBuf; diff --git a/ruff_cli/src/lib.rs b/ruff_cli/src/lib.rs index b731e83576..4b2cfffb36 100644 --- a/ruff_cli/src/lib.rs +++ b/ruff_cli/src/lib.rs @@ -2,6 +2,7 @@ //! to automatically update the `ruff --help` output in the `README.md`. //! //! For the actual Ruff library, see [`ruff`]. +#![forbid(unsafe_code)] #![allow(clippy::must_use_candidate, dead_code)] mod cli; diff --git a/ruff_cli/src/main.rs b/ruff_cli/src/main.rs index 5688829002..5fa29feed1 100644 --- a/ruff_cli/src/main.rs +++ b/ruff_cli/src/main.rs @@ -1,10 +1,10 @@ +#![forbid(unsafe_code)] #![allow( clippy::match_same_arms, clippy::missing_errors_doc, clippy::module_name_repetitions, clippy::too_many_lines )] -#![forbid(unsafe_code)] use std::io::{self}; use std::path::{Path, PathBuf}; diff --git a/ruff_dev/src/main.rs b/ruff_dev/src/main.rs index 3939fcbe4a..5453ef693b 100644 --- a/ruff_dev/src/main.rs +++ b/ruff_dev/src/main.rs @@ -1,6 +1,7 @@ //! This crate implements an internal CLI for developers of Ruff. //! //! Within the ruff repository you can run it with `cargo dev`. +#![forbid(unsafe_code)] #![allow( clippy::collapsible_else_if, clippy::collapsible_if, @@ -13,7 +14,6 @@ clippy::similar_names, clippy::too_many_lines )] -#![forbid(unsafe_code)] mod generate_all; mod generate_cli_help; diff --git a/ruff_macros/src/lib.rs b/ruff_macros/src/lib.rs index af526d3eaa..8b62ac464f 100644 --- a/ruff_macros/src/lib.rs +++ b/ruff_macros/src/lib.rs @@ -1,4 +1,5 @@ //! This crate implements internal macros for the `ruff` library. +#![forbid(unsafe_code)] #![allow( clippy::collapsible_else_if, clippy::collapsible_if, @@ -11,7 +12,6 @@ clippy::similar_names, clippy::too_many_lines )] -#![forbid(unsafe_code)] use proc_macro::TokenStream; use syn::{parse_macro_input, DeriveInput, ItemFn}; diff --git a/src/lib.rs b/src/lib.rs index fdcf9e177e..494e96aad9 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -4,6 +4,7 @@ //! and subject to change drastically. //! //! [Ruff]: https://github.com/charliermarsh/ruff +#![forbid(unsafe_code)] #![allow( clippy::collapsible_else_if, clippy::collapsible_if, @@ -16,7 +17,6 @@ clippy::similar_names, clippy::too_many_lines )] -#![forbid(unsafe_code)] mod ast; mod autofix;