Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-20 21:10:48 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix syntax error false positives for await outside functions (#21763)

Browse Source 
## Summary

Fixes #21750 and a related bug in `PLE1142`. We were not properly
considering generators to be valid `await` contexts, which caused the
`F704` issue. One of the tests I added for this also uncovered an issue
in `PLE1142` for comprehensions nested within async generators because
we were only checking the current scope rather than traversing the
nested context.

## Test Plan

Both of these rules are implemented as semantic syntax errors, so I
added tests (and fixes) in both Ruff and ty.
This commit is contained in:
Brent Westbrook
2025-12-02 16:02:02 -05:00
committed by GitHub
parent 392a8e4e50
commit 2250fa6f98
9 changed files with 147 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
crates/ruff_python_parser/src/semantic_errors.rs
View File

@@ -896,7 +896,7 @@ impl SemanticSyntaxChecker {
// This check is required in addition to avoiding calling this function in `visit_expr`
// because the generator scope applies to nested parts of the `Expr::Generator` that are
// visited separately.
if ctx.in_generator_scope() {
if ctx.in_generator_context() {
return;
}
Self::add_error(
@@ -2096,11 +2096,11 @@ pub trait SemanticSyntaxContext {
/// Returns `true` if the visitor is in a function scope.
fn in_function_scope(&self) -> bool;
/// Returns `true` if the visitor is in a generator scope.
/// Returns `true` if the visitor is within a generator scope.
///
/// Note that this refers to an `Expr::Generator` precisely, not to comprehensions more
/// generally.
fn in_generator_scope(&self) -> bool;
fn in_generator_context(&self) -> bool;
/// Returns `true` if the source file is a Jupyter notebook.
fn in_notebook(&self) -> bool;