Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ty] Fix completion order in playground (#18480)

This commit is contained in:
Micha Reiser 2025-06-05 18:55:54 +02:00 committed by GitHub
parent ce216c79cc
commit 28dbc5c51e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
playground/ty/src/Editor/Editor.tsx
View File

@ -202,9 +202,13 @@ class PlaygroundServer
new TyPosition(position.lineNumber, position.column), new TyPosition(position.lineNumber, position.column),
); );
// If completions is 100, this gives us "99" which has a length of two
const digitsLength = String(completions.length - 1).length;
return { return {
suggestions: completions.map((completion) => ({ suggestions: completions.map((completion, i) => ({
label: completion.label, label: completion.label,
sortText: String(i).padStart(digitsLength, "0"),
kind: CompletionItemKind.Variable, kind: CompletionItemKind.Variable,
insertText: completion.label, insertText: completion.label,
// TODO(micha): It's unclear why this field is required for monaco but not VS Code. // TODO(micha): It's unclear why this field is required for monaco but not VS Code.
@ -491,7 +495,7 @@ class PlaygroundServer
this.typeDefinitionProviderDisposable.dispose(); this.typeDefinitionProviderDisposable.dispose();
this.inlayHintsDisposable.dispose(); this.inlayHintsDisposable.dispose();
this.formatDisposable.dispose(); this.formatDisposable.dispose();
this.editorOpenerDisposable.dispose(); this.completionDisposable.dispose();
} }
} }