From 2a0946760fcd39a007f597d1340300c324d242b2 Mon Sep 17 00:00:00 2001 From: Brent Westbrook <36778786+ntBre@users.noreply.github.com> Date: Thu, 15 Jan 2026 12:18:22 -0500 Subject: [PATCH] Add trailing slashes to `npm publish` paths (#22603) Summary -- The WASM builds in the 0.14.12 release were failing with an error about trying to publish over an existing version 5.8.1 ([example]). This seems to be because it's trying to publish a package named `pkg` instead of the `pkg` directory. Micha found that a trailing slash causes `npm` to interpret the path correctly. Test Plan -- I think we can test this with a dry run of the release workflow, otherwise another release attempt for 0.14.12 [example]: https://github.com/astral-sh/ruff/actions/runs/21037103249/job/60492735499#step:5:281 --- .github/workflows/publish-wasm.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-wasm.yml b/.github/workflows/publish-wasm.yml index 786225f920..8db3e3748a 100644 --- a/.github/workflows/publish-wasm.yml +++ b/.github/workflows/publish-wasm.yml @@ -32,9 +32,9 @@ jobs: registry-url: "https://registry.npmjs.org" - name: "Publish (dry-run)" if: ${{ inputs.plan == '' || fromJson(inputs.plan).announcement_tag_is_implicit }} - run: npm publish --dry-run pkg + run: npm publish --dry-run pkg/ - name: "Publish" if: ${{ inputs.plan != '' && !fromJson(inputs.plan).announcement_tag_is_implicit }} - run: npm publish --provenance --access public pkg + run: npm publish --provenance --access public pkg/ env: NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}