Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

implement preview: use fluent more often

This commit is contained in:
dylwil3 2025-12-08 12:42:14 -06:00
parent 8ba316db88
commit 2a5d66bb13
1 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
crates/ruff_python_formatter/src/expression/mod.rs
View File

@ -993,10 +993,35 @@ impl CallChainLayout {
}
}
if attributes_after_parentheses + u32::from(first_attr_value_parenthesized) < 2 {
CallChainLayout::NonFluent
// Observe that `call_like_count >= attributes_after_parentheses`
//
// Indeed, the latter accumulates only at an attribute expression
// with non-parenthesized, call-like value. After that, we
// immediately set `was_in_call_like` to `true`. Any execution path
// from that code point to the exit or to the next accumulation of
// `attribute_after_parentheses` passes through
//
// ```
// call_like_count += u32::from(was_in_call_like);
// ```
//
// and it does so before it could pass through
// `was_in_call_like = false`.
//
// This justifies the name `fluent_layout_more_often_enabled`
// used below.
if is_fluent_layout_more_often_enabled(context) {
if call_like_count + u32::from(first_attr_value_parenthesized) < 2 {
CallChainLayout::NonFluent
} else {
CallChainLayout::Fluent(AttributeState::CallsOrSubscriptsPreceding(call_like_count))
}
} else {
CallChainLayout::Fluent(AttributeState::CallsOrSubscriptsPreceding(call_like_count))
if attributes_after_parentheses + u32::from(first_attr_value_parenthesized) < 2 {
CallChainLayout::NonFluent
} else {
CallChainLayout::Fluent(AttributeState::CallsOrSubscriptsPreceding(call_like_count))
}
}
}