Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ty] Remove `Self` from generic context when binding `Self` (#20364) 

## Summary

This mainly removes an internal inconsistency, where we didn't remove
the `Self` type variable when eagerly binding `Self` to an instance
type. It has no observable effect, apparently.

builds on top of https://github.com/astral-sh/ruff/pull/20328

## Test Plan

None
This commit is contained in:
David Peter 2025-09-15 17:40:10 +02:00 committed by GitHub
parent 25cbf38a47
commit 2a6dde4acb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
crates/ty_python_semantic/src/types.rs
View File

@ -6777,8 +6777,15 @@ impl<'db> TypeMapping<'_, 'db> {
| TypeMapping::PromoteLiterals | TypeMapping::PromoteLiterals
| TypeMapping::BindLegacyTypevars(_) | TypeMapping::BindLegacyTypevars(_)
| TypeMapping::MarkTypeVarsInferable(_) | TypeMapping::MarkTypeVarsInferable(_)
| TypeMapping::Materialize(_) | TypeMapping::Materialize(_) => context,
| TypeMapping::BindSelf(_) => context, TypeMapping::BindSelf(_) => GenericContext::from_typevar_instances(
db,
context
.variables(db)
.iter()
.filter(|var| !var.typevar(db).is_self(db))
.copied(),
),
TypeMapping::ReplaceSelf { new_upper_bound } => GenericContext::from_typevar_instances( TypeMapping::ReplaceSelf { new_upper_bound } => GenericContext::from_typevar_instances(
db, db,
context.variables(db).iter().map(|typevar| { context.variables(db).iter().map(|typevar| {