[syntax-errors]: break outside loop F701 (#20556)

<!--
Thank you for contributing to Ruff/ty! To help us out with reviewing,
please consider the following:

- Does this pull request include a summary of the change? (See below.)
- Does this pull request include a descriptive title? (Please prefix
with `[ty]` for ty pull
  requests.)
- Does this pull request include references to any relevant issues?
-->

## Summary

<!-- What's the purpose of the change? What does it do, and why? -->

This PR implements https://docs.astral.sh/ruff/rules/break-outside-loop/
(F701) as a semantic syntax error.

## Test Plan

<!-- How was it tested? -->

---------

Signed-off-by: 11happy <soni5happy@gmail.com>
Co-authored-by: Brent Westbrook <brentrwestbrook@gmail.com>
This commit is contained in:
Bhuminjay Soni
2025-10-14 01:30:59 +05:30
committed by GitHub
parent 4b8e278a88
commit 2b729b4d52
6 changed files with 51 additions and 41 deletions

View File

@@ -224,6 +224,11 @@ impl SemanticSyntaxChecker {
);
}
}
Stmt::Break(ast::StmtBreak { range, .. }) => {
if !ctx.in_loop_context() {
Self::add_error(ctx, SemanticSyntaxErrorKind::BreakOutsideLoop, *range);
}
}
_ => {}
}
@@ -1125,6 +1130,7 @@ impl Display for SemanticSyntaxError {
SemanticSyntaxErrorKind::FutureFeatureNotDefined(name) => {
write!(f, "Future feature `{name}` is not defined")
}
SemanticSyntaxErrorKind::BreakOutsideLoop => f.write_str("`break` outside loop"),
}
}
}
@@ -1498,6 +1504,9 @@ pub enum SemanticSyntaxErrorKind {
/// Represents the use of a `__future__` feature that is not defined.
FutureFeatureNotDefined(String),
/// Represents the use of a `break` statement outside of a loop.
BreakOutsideLoop,
}
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, get_size2::GetSize)]
@@ -1979,6 +1988,8 @@ pub trait SemanticSyntaxContext {
fn in_notebook(&self) -> bool;
fn report_semantic_error(&self, error: SemanticSyntaxError);
fn in_loop_context(&self) -> bool;
}
/// Modified version of [`std::str::EscapeDefault`] that does not escape single or double quotes.