Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Update fix for `literal-membership` (`PLR6201`) to be unsafe (#8097) 

Closes https://github.com/astral-sh/ruff/issues/8096
This commit is contained in:
Zanie Blue 2023-10-20 12:38:00 -05:00 committed by GitHub
parent ae41d6f30a
commit 348b649b5c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crates/ruff_linter/src/rules/pylint/rules/literal_membership.rs
View File

@ -59,7 +59,10 @@ pub(crate) fn literal_membership(checker: &mut Checker, compare: &ast::ExprCompa
let literal = checker.locator().slice(right); let literal = checker.locator().slice(right);
let set = format!("{{{}}}", &literal[1..literal.len() - 1]); let set = format!("{{{}}}", &literal[1..literal.len() - 1]);
diagnostic.set_fix(Fix::safe_edit(Edit::range_replacement(set, right.range()))); diagnostic.set_fix(Fix::unsafe_edit(Edit::range_replacement(
set,
right.range(),
)));
checker.diagnostics.push(diagnostic); checker.diagnostics.push(diagnostic);
} }

6
crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLR6201_literal_membership.py.snap
View File

@ -11,7 +11,7 @@ literal_membership.py:2:6: PLR6201 [*] Use a `set` literal when testing for memb
| |
= help: Convert to `set` = help: Convert to `set`
ℹ Fix ℹ Suggested fix
1 1 | # Errors 1 1 | # Errors
2 |-1 in [1, 2, 3] 2 |-1 in [1, 2, 3]
2 |+1 in {1, 2, 3} 2 |+1 in {1, 2, 3}
@ -30,7 +30,7 @@ literal_membership.py:3:6: PLR6201 [*] Use a `set` literal when testing for memb
| |
= help: Convert to `set` = help: Convert to `set`
ℹ Fix ℹ Suggested fix
1 1 | # Errors 1 1 | # Errors
2 2 | 1 in [1, 2, 3] 2 2 | 1 in [1, 2, 3]
3 |-1 in (1, 2, 3) 3 |-1 in (1, 2, 3)
@ -53,7 +53,7 @@ literal_membership.py:4:6: PLR6201 [*] Use a `set` literal when testing for memb
| |
= help: Convert to `set` = help: Convert to `set`
ℹ Fix ℹ Suggested fix
1 1 | # Errors 1 1 | # Errors
2 2 | 1 in [1, 2, 3] 2 2 | 1 in [1, 2, 3]
3 3 | 1 in (1, 2, 3) 3 3 | 1 in (1, 2, 3)