Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ty] _typeshed.Self is not a special form (#18377) 

## Summary

This change was based on a mis-reading of a comment in typeshed, and a
wrong assumption about what was causing a test failure in a prior PR.
Reverting it doesn't cause any tests to fail.

## Test Plan

Existing tests.
This commit is contained in:
Carl Meyer 2025-05-29 17:11:13 -07:00 committed by GitHub
parent 9b0dfc505f
commit 363f061f09
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/ty_python_semantic/src/types/special_form.rs
View File

@ -79,7 +79,7 @@ pub enum SpecialFormType {
/// The symbol `typing.Callable` /// The symbol `typing.Callable`
/// (which can also be found as `typing_extensions.Callable` or as `collections.abc.Callable`) /// (which can also be found as `typing_extensions.Callable` or as `collections.abc.Callable`)
Callable, Callable,
/// The symbol `typing.Self` (which can also be found as `typing_extensions.Self` or `_typeshed.Self`) /// The symbol `typing.Self` (which can also be found as `typing_extensions.Self`)
#[strum(serialize = "Self")] #[strum(serialize = "Self")]
TypingSelf, TypingSelf,
/// The symbol `typing.Final` (which can also be found as `typing_extensions.Final`) /// The symbol `typing.Final` (which can also be found as `typing_extensions.Final`)
@ -227,16 +227,12 @@ impl SpecialFormType {
| Self::TypeGuard | Self::TypeGuard
| Self::TypedDict | Self::TypedDict
| Self::TypeIs | Self::TypeIs
| Self::TypingSelf
| Self::Protocol | Self::Protocol
| Self::ReadOnly => { | Self::ReadOnly => {
matches!(module, KnownModule::Typing | KnownModule::TypingExtensions) matches!(module, KnownModule::Typing | KnownModule::TypingExtensions)
} }
Self::TypingSelf => matches!(
module,
KnownModule::Typing | KnownModule::TypingExtensions | KnownModule::Typeshed
),
Self::Unknown Self::Unknown
| Self::AlwaysTruthy | Self::AlwaysTruthy
| Self::AlwaysFalsy | Self::AlwaysFalsy