Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Formatting, replace vec with array to avoid unnecessary allocs

This commit is contained in:
Patrick Haller 2022-09-14 15:16:24 +02:00
parent a05898683e
commit 3a625599f4
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/main.rs
View File

@ -1,5 +1,5 @@
use std::io::{stdout, BufWriter, Write}; use std::io::{stdout, BufWriter, Write};
use std::path::{Path, PathBuf}; use std::path::PathBuf;
use std::process::ExitCode; use std::process::ExitCode;
use std::sync::mpsc::channel; use std::sync::mpsc::channel;
use std::time::Instant; use std::time::Instant;
@ -142,7 +142,7 @@ fn inner_main() -> Result<ExitCode> {
let mut settings = Settings::from_paths(&cli.files); let mut settings = Settings::from_paths(&cli.files);
let mut printer = Printer::new(BufWriter::new(stdout()), cli.format); let mut printer = Printer::new(BufWriter::new(stdout()), cli.format);
if !cli.select.is_empty() { if !cli.select.is_empty() {
settings.select(cli.select); settings.select(cli.select);
} }
@ -164,7 +164,7 @@ fn inner_main() -> Result<ExitCode> {
let messages = run_once(&cli.files, &settings, !cli.no_cache, false)?; let messages = run_once(&cli.files, &settings, !cli.no_cache, false)?;
if !cli.quiet { if !cli.quiet {
printer.write_continuously(messages)?; printer.write_continuously(&messages)?;
} }
// Configure the file watcher. // Configure the file watcher.
@ -184,7 +184,7 @@ fn inner_main() -> Result<ExitCode> {
let messages = run_once(&cli.files, &settings, !cli.no_cache, false)?; let messages = run_once(&cli.files, &settings, !cli.no_cache, false)?;
if !cli.quiet { if !cli.quiet {
printer.write_continuously(messages)?; printer.write_continuously(&messages)?;
} }
} }
} }

4
src/printer.rs
View File

@ -23,7 +23,7 @@ impl<W: Write> Printer<W> {
Self { writer, format } Self { writer, format }
} }
pub fn write_once(&mut self, messages: &Vec<Message>) -> Result<()> { pub fn write_once(&mut self, messages: &[Message]) -> Result<()> {
let (fixed, outstanding): (Vec<&Message>, Vec<&Message>) = let (fixed, outstanding): (Vec<&Message>, Vec<&Message>) =
messages.iter().partition(|message| message.fixed); messages.iter().partition(|message| message.fixed);
let num_fixable = outstanding let num_fixable = outstanding
@ -63,7 +63,7 @@ impl<W: Write> Printer<W> {
Ok(()) Ok(())
} }
pub fn write_continuously(&mut self, messages: Vec<Message>) -> Result<()> { pub fn write_continuously(&mut self, messages: &[Message]) -> Result<()> {
tell_user!( tell_user!(
self.writer, self.writer,
"Found {} error(s). Watching for file changes.", "Found {} error(s). Watching for file changes.",