mirror of https://github.com/astral-sh/ruff
put similar dunder-call tests next to each other (#18343)
Follow-up from post-land review on https://github.com/astral-sh/ruff/pull/18260
This commit is contained in:
parent
3e811fc369
commit
3eada01153
|
|
@ -59,6 +59,8 @@ ClassWithNormalDunder[0]
|
||||||
|
|
||||||
## Operating on instances
|
## Operating on instances
|
||||||
|
|
||||||
|
### Attaching dunder methods to instances in methods
|
||||||
|
|
||||||
When invoking a dunder method on an instance of a class, it is looked up on the class:
|
When invoking a dunder method on an instance of a class, it is looked up on the class:
|
||||||
|
|
||||||
```py
|
```py
|
||||||
|
|
@ -116,6 +118,40 @@ def _(flag: bool):
|
||||||
reveal_type(this_fails[0]) # revealed: Unknown | str
|
reveal_type(this_fails[0]) # revealed: Unknown | str
|
||||||
```
|
```
|
||||||
|
|
||||||
|
### Dunder methods as class-level annotations with no value
|
||||||
|
|
||||||
|
Class-level annotations with no value assigned are considered instance-only, and aren't available as
|
||||||
|
dunder methods:
|
||||||
|
|
||||||
|
```py
|
||||||
|
from typing import Callable
|
||||||
|
|
||||||
|
class C:
|
||||||
|
__call__: Callable[..., None]
|
||||||
|
|
||||||
|
# error: [call-non-callable]
|
||||||
|
C()()
|
||||||
|
|
||||||
|
# error: [invalid-assignment]
|
||||||
|
_: Callable[..., None] = C()
|
||||||
|
```
|
||||||
|
|
||||||
|
And of course the same is true if we have only an implicit assignment inside a method:
|
||||||
|
|
||||||
|
```py
|
||||||
|
from typing import Callable
|
||||||
|
|
||||||
|
class C:
|
||||||
|
def __init__(self):
|
||||||
|
self.__call__ = lambda *a, **kw: None
|
||||||
|
|
||||||
|
# error: [call-non-callable]
|
||||||
|
C()()
|
||||||
|
|
||||||
|
# error: [invalid-assignment]
|
||||||
|
_: Callable[..., None] = C()
|
||||||
|
```
|
||||||
|
|
||||||
## When the dunder is not a method
|
## When the dunder is not a method
|
||||||
|
|
||||||
A dunder can also be a non-method callable:
|
A dunder can also be a non-method callable:
|
||||||
|
|
@ -239,37 +275,3 @@ def _(flag: bool):
|
||||||
# error: [possibly-unbound-implicit-call]
|
# error: [possibly-unbound-implicit-call]
|
||||||
reveal_type(c[0]) # revealed: str
|
reveal_type(c[0]) # revealed: str
|
||||||
```
|
```
|
||||||
|
|
||||||
## Dunder methods cannot be looked up on instances
|
|
||||||
|
|
||||||
Class-level annotations with no value assigned are considered instance-only, and aren't available as
|
|
||||||
dunder methods:
|
|
||||||
|
|
||||||
```py
|
|
||||||
from typing import Callable
|
|
||||||
|
|
||||||
class C:
|
|
||||||
__call__: Callable[..., None]
|
|
||||||
|
|
||||||
# error: [call-non-callable]
|
|
||||||
C()()
|
|
||||||
|
|
||||||
# error: [invalid-assignment]
|
|
||||||
_: Callable[..., None] = C()
|
|
||||||
```
|
|
||||||
|
|
||||||
And of course the same is true if we have only an implicit assignment inside a method:
|
|
||||||
|
|
||||||
```py
|
|
||||||
from typing import Callable
|
|
||||||
|
|
||||||
class C:
|
|
||||||
def __init__(self):
|
|
||||||
self.__call__ = lambda *a, **kw: None
|
|
||||||
|
|
||||||
# error: [call-non-callable]
|
|
||||||
C()()
|
|
||||||
|
|
||||||
# error: [invalid-assignment]
|
|
||||||
_: Callable[..., None] = C()
|
|
||||||
```
|
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue