Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-09 15:44:22 -05:00
Code Issues Packages Projects Releases Wiki Activity

[ty] Make Module a Salsa ingredient

Browse Source 
We want to write queries that depend on `Module` for caching. While it
seems it can be done without making `Module` an ingredient, it seems it
is best practice to do so.

[best practice to do so]: https://github.com/astral-sh/ruff/pull/19408#discussion_r2215867301
This commit is contained in:
Andrew Gallant
2025-07-18 14:15:42 -04:00
committed by Andrew Gallant
parent 905b9d7f51
commit 4573a0f6a0
24 changed files with 258 additions and 253 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
crates/ruff_python_semantic/src/analyze/visibility.rs
View File

@@ -163,7 +163,7 @@ fn stem(path: &str) -> &str {
}
/// Infer the [`Visibility`] of a module from its path.
pub(crate) fn module_visibility(module: &Module) -> Visibility {
pub(crate) fn module_visibility(module: Module) -> Visibility {
match &module.source {
ModuleSource::Path(path) => {
if path.iter().any(|m| is_private_module(m)) {

2
crates/ruff_python_semantic/src/definition.rs
View File

@@ -223,7 +223,7 @@ impl<'a> Definitions<'a> {
// visibility.
let visibility = {
match &definition {
Definition::Module(module) => module_visibility(module),
Definition::Module(module) => module_visibility(*module),
Definition::Member(member) => match member.kind {
MemberKind::Class(class) => {
let parent = &definitions[member.parent];