Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

add TODO about lazy source_order adjustment

This commit is contained in:
Douglas Creager 2025-12-15 13:51:46 -05:00
parent c085745b9e
commit 4847fe168e
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crates/ty_python_semantic/src/types/constraints.rs
View File

@ -1085,6 +1085,11 @@ impl<'db> Node<'db> {
fn or_with_offset(self, db: &'db dyn Db, other: Self) -> Self { fn or_with_offset(self, db: &'db dyn Db, other: Self) -> Self {
// To ensure that `self` appears before `other` in `source_order`, we add the maximum // To ensure that `self` appears before `other` in `source_order`, we add the maximum
// `source_order` of the lhs to all of the `source_order`s in the rhs. // `source_order` of the lhs to all of the `source_order`s in the rhs.
//
// TODO: If we store `other_offset` as a new field on InteriorNode, we might be able to
// avoid all of the extra work in the calls to with_adjusted_source_order, and apply the
// adjustment lazily when walking a BDD tree. (ditto below in the other _with_offset
// methods)
let other_offset = self.max_source_order(db); let other_offset = self.max_source_order(db);
self.or_inner(db, other, other_offset) self.or_inner(db, other, other_offset)
} }