Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

don't overwrite source_order

This commit is contained in:
Douglas Creager 2025-12-15 21:35:58 -05:00
parent ae249b8472
commit 4be6d19e5a
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
crates/ty_python_semantic/src/types/constraints.rs
View File

@ -72,6 +72,7 @@ use std::fmt::Display;
use std::ops::Range; use std::ops::Range;
use itertools::Itertools; use itertools::Itertools;
use ordermap::map::Entry;
use rustc_hash::{FxHashMap, FxHashSet}; use rustc_hash::{FxHashMap, FxHashSet};
use salsa::plumbing::AsId; use salsa::plumbing::AsId;
@ -3415,9 +3416,11 @@ impl<'db> PathAssignments<'db> {
); );
return Err(PathAssignmentConflict); return Err(PathAssignmentConflict);
} }
if self.assignments.insert(assignment, source_order).is_some() {
return Ok(()); match self.assignments.entry(assignment) {
} Entry::Vacant(entry) => entry.insert(source_order),
Entry::Occupied(_) => return Ok(()),
};
// Then use our sequents to add additional facts that we know to be true. We currently // Then use our sequents to add additional facts that we know to be true. We currently
// reuse the `source_order` of the "real" constraint passed into `walk_edge` when we add // reuse the `source_order` of the "real" constraint passed into `walk_edge` when we add