From 4bf48e04fcf890c3213b98acb9d5faffc1ff6db8 Mon Sep 17 00:00:00 2001 From: Jonas Vacek Date: Mon, 6 Oct 2025 20:43:42 +0200 Subject: [PATCH] Exlicitly check for just arguments as well --- .../test/fixtures/flake8_django/DJ014.py | 1 + .../test/fixtures/flake8_django/DJ015.py | 1 + ..._flake8_django__tests__DJ014_DJ014.py.snap | 23 +++++++++++++++++-- ..._flake8_django__tests__DJ015_DJ015.py.snap | 23 +++++++++++++++++-- 4 files changed, 44 insertions(+), 4 deletions(-) diff --git a/crates/ruff_linter/resources/test/fixtures/flake8_django/DJ014.py b/crates/ruff_linter/resources/test/fixtures/flake8_django/DJ014.py index e0943da309..556a3c5495 100644 --- a/crates/ruff_linter/resources/test/fixtures/flake8_django/DJ014.py +++ b/crates/ruff_linter/resources/test/fixtures/flake8_django/DJ014.py @@ -42,4 +42,5 @@ urlpatterns_mixed = [ # Error - missing trail slash and argument should stay in message urlpatterns_params_bad = [ path("bad/", views.bad_view), # DJ014 + path("", views.bad_view), # DJ014 ] diff --git a/crates/ruff_linter/resources/test/fixtures/flake8_django/DJ015.py b/crates/ruff_linter/resources/test/fixtures/flake8_django/DJ015.py index 23d30b6c05..c169fff641 100644 --- a/crates/ruff_linter/resources/test/fixtures/flake8_django/DJ015.py +++ b/crates/ruff_linter/resources/test/fixtures/flake8_django/DJ015.py @@ -50,4 +50,5 @@ urlpatterns_quotes = [ # Error - leading trail slash and argument should stay in message urlpatterns_params_bad = [ path("/bad//", views.bad_view), # DJ015 + path("/", views.bad_view), # DJ014 ] diff --git a/crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ014_DJ014.py.snap b/crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ014_DJ014.py.snap index 62842d19a0..5ce447bfa5 100644 --- a/crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ014_DJ014.py.snap +++ b/crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ014_DJ014.py.snap @@ -146,7 +146,8 @@ DJ014 [*] URL route `bad/` is missing a trailing slash 43 | urlpatterns_params_bad = [ 44 | path("bad/", views.bad_view), # DJ014 | ^^^^^^^^^^^^^^^^^ -45 | ] +45 | path("", views.bad_view), # DJ014 +46 | ] | help: Add trailing slash 41 | @@ -154,4 +155,22 @@ help: Add trailing slash 43 | urlpatterns_params_bad = [ - path("bad/", views.bad_view), # DJ014 44 + path("bad//", views.bad_view), # DJ014 -45 | ] +45 | path("", views.bad_view), # DJ014 +46 | ] + +DJ014 [*] URL route `` is missing a trailing slash + --> DJ014.py:45:10 + | +43 | urlpatterns_params_bad = [ +44 | path("bad/", views.bad_view), # DJ014 +45 | path("", views.bad_view), # DJ014 + | ^^^^^^^^^^^^^ +46 | ] + | +help: Add trailing slash +42 | # Error - missing trail slash and argument should stay in message +43 | urlpatterns_params_bad = [ +44 | path("bad/", views.bad_view), # DJ014 + - path("", views.bad_view), # DJ014 +45 + path("/", views.bad_view), # DJ014 +46 | ] diff --git a/crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ015_DJ015.py.snap b/crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ015_DJ015.py.snap index 7e984411dd..9da395bbf7 100644 --- a/crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ015_DJ015.py.snap +++ b/crates/ruff_linter/src/rules/flake8_django/snapshots/ruff_linter__rules__flake8_django__tests__DJ015_DJ015.py.snap @@ -225,7 +225,8 @@ DJ015 [*] URL route `/bad//` has an unnecessary leading slash 51 | urlpatterns_params_bad = [ 52 | path("/bad//", views.bad_view), # DJ015 | ^^^^^^^^^^^^^^^^^^^ -53 | ] +53 | path("/", views.bad_view), # DJ014 +54 | ] | help: Remove leading slash 49 | @@ -233,4 +234,22 @@ help: Remove leading slash 51 | urlpatterns_params_bad = [ - path("/bad//", views.bad_view), # DJ015 52 + path("bad//", views.bad_view), # DJ015 -53 | ] +53 | path("/", views.bad_view), # DJ014 +54 | ] + +DJ015 [*] URL route `/` has an unnecessary leading slash + --> DJ015.py:53:10 + | +51 | urlpatterns_params_bad = [ +52 | path("/bad//", views.bad_view), # DJ015 +53 | path("/", views.bad_view), # DJ014 + | ^^^^^^^^^^^^^^ +54 | ] + | +help: Remove leading slash +50 | # Error - leading trail slash and argument should stay in message +51 | urlpatterns_params_bad = [ +52 | path("/bad//", views.bad_view), # DJ015 + - path("/", views.bad_view), # DJ014 +53 + path("", views.bad_view), # DJ014 +54 | ]