Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-09 23:54:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make formatter ecosystem check failure output better understandable (#6300)

Browse Source 
**Summary** Prompted by
https://github.com/astral-sh/ruff/pull/6257#issuecomment-1661308410, it
tried to make the ecosystem script output on failure better
understandable. All log messages are now written to a file, which is
printed on error. Running locally progress is still shown.

Looking through the log output i saw that we currently log syntax errors
in input, which is confusing because they aren't actual errors, but we
don't check that these files don't change due to parser regressions or
improvements. I added `--files-with-errors` to catch that.

**Test Plan** CI
This commit is contained in:
konsti
2023-08-03 20:23:25 +02:00
committed by GitHub
parent b3f3529499
commit 51ff98f9e9
3 changed files with 76 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
scripts/formatter_ecosystem_checks.sh
View File

@@ -41,19 +41,24 @@ if [ ! -d "$dir/warehouse" ]; then
git clone --filter=tree:0 https://github.com/pypi/warehouse "$dir/warehouse"
git -C "$dir/warehouse" checkout fe6455c0a946e81f61d72edc1049f536d8bba903
fi
# django project
# zulip, a django user
if [ ! -d "$dir/zulip" ]; then
git clone --filter=tree:0 https://github.com/zulip/zulip "$dir/zulip"
git -C "$dir/zulip" checkout 6cb080c4479546a7f5cb017fcddea56605910b48
fi
# cpython itself
if [ ! -d "$dir/cpython" ]; then
git clone --filter=tree:0 https://github.com/python/cpython "$dir/cpython"
git -C "$dir/cpython" checkout 45de31db9cc9be945702f3a7ca35bbb9f98476af
fi
# Uncomment if you want to update the hashes
# for i in "$dir"/*/; do git -C "$i" switch main && git -C "$i" pull && echo "# $(basename "$i") $(git -C "$i" rev-parse HEAD)"; done
time cargo run --bin ruff_dev -- format-dev --stability-check --error-file "$target/progress_projects_errors.txt" \
--multi-project "$dir" >"$target/progress_projects_report.txt" || (
--log-file "$target/progress_projects_log.txt" --files-with-errors 25 --multi-project "$dir" || (
echo "Ecosystem check failed"
cat "$target/progress_projects_report.txt"
cat "$target/progress_projects_log.txt"
exit 1
)
grep "similarity index" "$target/progress_projects_report.txt" | sort
grep "similarity index" "$target/progress_projects_log.txt" | sort