Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[ty] Avoid inferring types for invalid binary expressions in string annotations (#21911) 

## Summary

Closes https://github.com/astral-sh/ty/issues/1847.

---------

Co-authored-by: David Peter <mail@david-peter.de>
This commit is contained in:
Charlie Marsh 2025-12-11 03:40:19 -05:00 committed by GitHub
parent 24ed28e314
commit 5c320990f7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
crates/ty_python_semantic/resources/mdtest/annotations/string.md
View File

@ -156,6 +156,9 @@ a: "1 or 2"
b: "(x := 1)" b: "(x := 1)"
# error: [invalid-type-form] # error: [invalid-type-form]
c: "1 + 2" c: "1 + 2"
# Regression test for https://github.com/astral-sh/ty/issues/1847
# error: [invalid-type-form]
c2: "a*(i for i in [])"
d: "lambda x: x" d: "lambda x: x"
e: "x if True else y" e: "x if True else y"
f: "{'a': 1, 'b': 2}" f: "{'a': 1, 'b': 2}"

1
crates/ty_python_semantic/src/types/infer/builder/type_expression.rs
View File

@ -155,7 +155,6 @@ impl<'db> TypeInferenceBuilder<'db, '_> {
} }
// anything else is an invalid annotation: // anything else is an invalid annotation:
op => { op => {
self.infer_binary_expression(binary, TypeContext::default());
self.report_invalid_type_expression( self.report_invalid_type_expression(
expression, expression,
format_args!( format_args!(