From 601848d9a808fbdf0d01553eb994ece322009444 Mon Sep 17 00:00:00 2001 From: Martin Fischer Date: Tue, 17 Jan 2023 06:02:53 +0100 Subject: [PATCH] refactor: Rename RuleOrigin::title to RuleOrigin::name --- ruff_cli/src/commands.rs | 4 ++-- ruff_dev/src/generate_rules_table.rs | 8 ++++---- src/registry.rs | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ruff_cli/src/commands.rs b/ruff_cli/src/commands.rs index 5509cce87b..d5e3e9e23b 100644 --- a/ruff_cli/src/commands.rs +++ b/ruff_cli/src/commands.rs @@ -296,7 +296,7 @@ pub fn explain(code: &RuleCode, format: SerializationFormat) -> Result<()> { println!( "{} ({}): {}", code.as_ref(), - code.origin().title(), + code.origin().name(), code.kind().summary() ); } @@ -305,7 +305,7 @@ pub fn explain(code: &RuleCode, format: SerializationFormat) -> Result<()> { "{}", serde_json::to_string_pretty(&Explanation { code: code.as_ref(), - origin: code.origin().title(), + origin: code.origin().name(), summary: &code.kind().summary(), })? ); diff --git a/ruff_dev/src/generate_rules_table.rs b/ruff_dev/src/generate_rules_table.rs index dad9f59106..15fdc5763e 100644 --- a/ruff_dev/src/generate_rules_table.rs +++ b/ruff_dev/src/generate_rules_table.rs @@ -47,22 +47,22 @@ pub fn main(cli: &Cli) -> Result<()> { for origin in RuleOrigin::iter() { let prefixes = origin.prefixes(); let codes_csv: String = prefixes.as_list(", "); - table_out.push_str(&format!("### {} ({codes_csv})", origin.title())); + table_out.push_str(&format!("### {} ({codes_csv})", origin.name())); table_out.push('\n'); table_out.push('\n'); toc_out.push_str(&format!( " 1. [{} ({})](#{}-{})\n", - origin.title(), + origin.name(), codes_csv, - origin.title().to_lowercase().replace(' ', "-"), + origin.name().to_lowercase().replace(' ', "-"), codes_csv.to_lowercase().replace(',', "-").replace(' ', "") )); if let Some((url, platform)) = origin.url() { table_out.push_str(&format!( "For more, see [{}]({}) on {}.", - origin.title(), + origin.name(), url, platform )); diff --git a/src/registry.rs b/src/registry.rs index 2034a38cb8..62cf340c63 100644 --- a/src/registry.rs +++ b/src/registry.rs @@ -495,7 +495,7 @@ impl Prefixes { } impl RuleOrigin { - pub fn title(&self) -> &'static str { + pub fn name(&self) -> &'static str { match self { RuleOrigin::Eradicate => "eradicate", RuleOrigin::Flake82020 => "flake8-2020",