From 602a27c4e3861757e9d78257f49c58bb823d43b9 Mon Sep 17 00:00:00 2001 From: Andrew Gallant Date: Mon, 17 Mar 2025 10:59:52 -0400 Subject: [PATCH] ruff_db: tweak number of line terminators emitted in new diagnostic renderer When moving over to the new renderer, I noticed that it was emitting an extra line terminator compared to the status quo. This removes it by turning the line terminator into a line delimiter between diagnostics. --- crates/ruff_db/src/diagnostic/render.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/crates/ruff_db/src/diagnostic/render.rs b/crates/ruff_db/src/diagnostic/render.rs index 8edbf5b68b..2161393bf1 100644 --- a/crates/ruff_db/src/diagnostic/render.rs +++ b/crates/ruff_db/src/diagnostic/render.rs @@ -47,8 +47,11 @@ impl std::fmt::Display for DisplayDiagnostic<'_> { fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result { let resolved = Resolved::new(self.resolver, self.diag); let renderable = resolved.to_renderable(self.config.context); - for diag in &renderable.diagnostics { - writeln!(f, "{}", self.annotate_renderer.render(diag.to_annotate()))?; + for (i, diag) in renderable.diagnostics.iter().enumerate() { + if i > 0 { + writeln!(f)?; + } + write!(f, "{}", self.annotate_renderer.render(diag.to_annotate()))?; } Ok(()) }