From 6a025d1925c9e5eb4b8e74ef1925dca3d2d7130f Mon Sep 17 00:00:00 2001 From: Andrew Gallant Date: Thu, 4 Dec 2025 12:08:10 -0500 Subject: [PATCH] [ty] Redact ranking of completions from e2e LSP tests I think changes to this value are generally noise. It's hard to tell what it means and it isn't especially actionable. We already have an eval running in CI for completion ranking, so I don't think it's terribly important to care about ranking here in e2e tests _generally_. --- crates/ty_server/tests/e2e/notebook.rs | 26 ++++++++++++++++--- .../snapshots/e2e__notebook__auto_import.snap | 4 +-- .../e2e__notebook__auto_import_docstring.snap | 4 +-- ...2e__notebook__auto_import_from_future.snap | 4 +-- .../e2e__notebook__auto_import_same_cell.snap | 4 +-- 5 files changed, 30 insertions(+), 12 deletions(-) diff --git a/crates/ty_server/tests/e2e/notebook.rs b/crates/ty_server/tests/e2e/notebook.rs index 4deb2bed17..b8cb10643b 100644 --- a/crates/ty_server/tests/e2e/notebook.rs +++ b/crates/ty_server/tests/e2e/notebook.rs @@ -5,6 +5,8 @@ use ty_server::ClientOptions; use crate::{TestServer, TestServerBuilder}; +static FILTERS: &[(&str, &str)] = &[(r#""sortText": "[0-9 ]+""#, r#""sortText": "[RANKING]""#)]; + #[test] fn publish_diagnostics_open() -> anyhow::Result<()> { let mut server = TestServerBuilder::new()? @@ -309,7 +311,11 @@ b: Litera let completions = literal_completions(&mut server, &second_cell, Position::new(1, 9)); - assert_json_snapshot!(completions); + insta::with_settings!({ + filters => FILTERS.iter().copied(), + }, { + assert_json_snapshot!(completions); + }); Ok(()) } @@ -340,7 +346,11 @@ b: Litera let completions = literal_completions(&mut server, &first_cell, Position::new(1, 9)); - assert_json_snapshot!(completions); + insta::with_settings!({ + filters => FILTERS.iter().copied(), + }, { + assert_json_snapshot!(completions); + }); Ok(()) } @@ -373,7 +383,11 @@ b: Litera let completions = literal_completions(&mut server, &second_cell, Position::new(1, 9)); - assert_json_snapshot!(completions); + insta::with_settings!({ + filters => FILTERS.iter().copied(), + }, { + assert_json_snapshot!(completions); + }); Ok(()) } @@ -409,7 +423,11 @@ b: Litera let completions = literal_completions(&mut server, &second_cell, Position::new(1, 9)); - assert_json_snapshot!(completions); + insta::with_settings!({ + filters => FILTERS.iter().copied(), + }, { + assert_json_snapshot!(completions); + }); Ok(()) } diff --git a/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import.snap b/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import.snap index 772f80a795..a9740b7b97 100644 --- a/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import.snap +++ b/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import.snap @@ -6,7 +6,7 @@ expression: completions { "label": "Literal (import typing)", "kind": 6, - "sortText": " 35", + "sortText": "[RANKING]", "insertText": "Literal", "additionalTextEdits": [ { @@ -27,7 +27,7 @@ expression: completions { "label": "LiteralString (import typing)", "kind": 6, - "sortText": " 36", + "sortText": "[RANKING]", "insertText": "LiteralString", "additionalTextEdits": [ { diff --git a/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_docstring.snap b/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_docstring.snap index 772f80a795..a9740b7b97 100644 --- a/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_docstring.snap +++ b/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_docstring.snap @@ -6,7 +6,7 @@ expression: completions { "label": "Literal (import typing)", "kind": 6, - "sortText": " 35", + "sortText": "[RANKING]", "insertText": "Literal", "additionalTextEdits": [ { @@ -27,7 +27,7 @@ expression: completions { "label": "LiteralString (import typing)", "kind": 6, - "sortText": " 36", + "sortText": "[RANKING]", "insertText": "LiteralString", "additionalTextEdits": [ { diff --git a/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_from_future.snap b/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_from_future.snap index 772f80a795..a9740b7b97 100644 --- a/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_from_future.snap +++ b/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_from_future.snap @@ -6,7 +6,7 @@ expression: completions { "label": "Literal (import typing)", "kind": 6, - "sortText": " 35", + "sortText": "[RANKING]", "insertText": "Literal", "additionalTextEdits": [ { @@ -27,7 +27,7 @@ expression: completions { "label": "LiteralString (import typing)", "kind": 6, - "sortText": " 36", + "sortText": "[RANKING]", "insertText": "LiteralString", "additionalTextEdits": [ { diff --git a/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_same_cell.snap b/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_same_cell.snap index 004f9f6823..713c26841e 100644 --- a/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_same_cell.snap +++ b/crates/ty_server/tests/e2e/snapshots/e2e__notebook__auto_import_same_cell.snap @@ -6,7 +6,7 @@ expression: completions { "label": "Literal (import typing)", "kind": 6, - "sortText": " 35", + "sortText": "[RANKING]", "insertText": "Literal", "additionalTextEdits": [ { @@ -27,7 +27,7 @@ expression: completions { "label": "LiteralString (import typing)", "kind": 6, - "sortText": " 36", + "sortText": "[RANKING]", "insertText": "LiteralString", "additionalTextEdits": [ {