[`pylint`] Mark `PLC0207` fixes as unsafe when `*args` unpacking is present (#19679)

## Summary

Fixes #19660

crates/ruff_linter/resources/test/fixtures/pylint/missing_maxsplit_arg.py

@@ -182,3 +182,13 @@ kwargs_with_maxsplit = {"maxsplit": 1}
 "1,2,3".split(",", **kwargs_with_maxsplit)[0]  # TODO: false positive
 kwargs_with_maxsplit = {"sep": ",", "maxsplit": 1}
 "1,2,3".split(**kwargs_with_maxsplit)[0]  # TODO: false positive
+
+
+## Test unpacked list literal args (starred expressions)
+# Errors
+"1,2,3".split(",", *[-1])[0]
+
+## Test unpacked list variable args
+# Errors
+args_list = [-1]
+"1,2,3".split(",", *args_list)[0]

crates/ruff_linter/src/rules/pylint/rules/missing_maxsplit_arg.rs

@@ -38,8 +38,8 @@ use crate::{AlwaysFixableViolation, Applicability, Edit, Fix};
 /// ```
 ///
 /// ## Fix Safety
-/// This rule's fix is marked as unsafe for `split()`/`rsplit()` calls that contain `**kwargs`, as
+/// This rule's fix is marked as unsafe for `split()`/`rsplit()` calls that contain `*args` or `**kwargs` arguments, as
-/// adding a `maxsplit` keyword to such a call may lead to a duplicate keyword argument error.
+/// adding a `maxsplit` argument to such a call may lead to duplicated arguments.
 #[derive(ViolationMetadata)]
 pub(crate) struct MissingMaxsplitArg {
     actual_split_type: String,
@@ -201,11 +201,12 @@ pub(crate) fn missing_maxsplit_arg(checker: &Checker, value: &Expr, slice: &Expr
     diagnostic.set_fix(Fix::applicable_edits(
         maxsplit_argument_edit,
         split_type_edit,
-        // If keyword.arg is `None` (i.e. if the function call contains `**kwargs`), mark the fix as unsafe
+        // Mark the fix as unsafe, if there are `*args` or `**kwargs`
-        if arguments
+        if arguments.args.iter().any(Expr::is_starred_expr)
-            .keywords
+            || arguments
-            .iter()
+                .keywords
-            .any(|keyword| keyword.arg.is_none())
+                .iter()
+                .any(|keyword| keyword.arg.is_none())
         {
             Applicability::Unsafe
         } else {

crates/ruff_linter/src/rules/pylint/snapshots/ruff_linter__rules__pylint__tests__PLC0207_missing_maxsplit_arg.py.snap

@@ -676,6 +676,7 @@ missing_maxsplit_arg.py:182:1: PLC0207 [*] Replace with `split(..., maxsplit=1)`
     182 |+"1,2,3".split(",", maxsplit=1, **kwargs_with_maxsplit)[0]  # TODO: false positive
 183 183 | kwargs_with_maxsplit = {"sep": ",", "maxsplit": 1}
 184 184 | "1,2,3".split(**kwargs_with_maxsplit)[0]  # TODO: false positive
+185 185 | 
 
 missing_maxsplit_arg.py:184:1: PLC0207 [*] Replace with `split(..., maxsplit=1)`.
     |
@@ -692,3 +693,43 @@ missing_maxsplit_arg.py:184:1: PLC0207 [*] Replace with `split(..., maxsplit=1)`
 183 183 | kwargs_with_maxsplit = {"sep": ",", "maxsplit": 1}
 184     |-"1,2,3".split(**kwargs_with_maxsplit)[0]  # TODO: false positive
     184 |+"1,2,3".split(maxsplit=1, **kwargs_with_maxsplit)[0]  # TODO: false positive
+185 185 | 
+186 186 | 
+187 187 | ## Test unpacked list literal args (starred expressions)
+
+missing_maxsplit_arg.py:189:1: PLC0207 [*] Replace with `split(..., maxsplit=1)`.
+    |
+187 | ## Test unpacked list literal args (starred expressions)
+188 | # Errors
+189 | "1,2,3".split(",", *[-1])[0]
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PLC0207
+190 |
+191 | ## Test unpacked list variable args
+    |
+    = help: Pass `maxsplit=1` into `str.split()`
+
+ℹ Unsafe fix
+186 186 | 
+187 187 | ## Test unpacked list literal args (starred expressions)
+188 188 | # Errors
+189     |-"1,2,3".split(",", *[-1])[0]
+    189 |+"1,2,3".split(",", *[-1], maxsplit=1)[0]
+190 190 | 
+191 191 | ## Test unpacked list variable args
+192 192 | # Errors
+
+missing_maxsplit_arg.py:194:1: PLC0207 [*] Replace with `split(..., maxsplit=1)`.
+    |
+192 | # Errors
+193 | args_list = [-1]
+194 | "1,2,3".split(",", *args_list)[0]
+    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PLC0207
+    |
+    = help: Pass `maxsplit=1` into `str.split()`
+
+ℹ Unsafe fix
+191 191 | ## Test unpacked list variable args
+192 192 | # Errors
+193 193 | args_list = [-1]
+194     |-"1,2,3".split(",", *args_list)[0]
+    194 |+"1,2,3".split(",", *args_list, maxsplit=1)[0]