Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid false-positive in chained type calls (#2663)

This commit is contained in:
Charlie Marsh 2023-02-08 12:18:36 -05:00 committed by GitHub
parent 9f9f25ff7c
commit 7482a4a5b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/ruff/resources/test/fixtures/pyupgrade/UP003.py vendored
View File

@ -10,3 +10,4 @@ y = x.dtype.type(0.0)
# OK # OK
type = lambda *args, **kwargs: None type = lambda *args, **kwargs: None
type("") type("")
type(arg)(" ")

2
crates/ruff/src/checkers/ast.rs
View File

@ -2280,7 +2280,7 @@ where
// pyupgrade // pyupgrade
if self.settings.rules.enabled(&Rule::TypeOfPrimitive) { if self.settings.rules.enabled(&Rule::TypeOfPrimitive) {
pyupgrade::rules::type_of_primitive(self, expr, func, args); pyupgrade::rules::type_of_primitive(self, expr, args);
} }
if self.settings.rules.enabled(&Rule::DeprecatedUnittestAlias) { if self.settings.rules.enabled(&Rule::DeprecatedUnittestAlias) {
pyupgrade::rules::deprecated_unittest_alias(self, func); pyupgrade::rules::deprecated_unittest_alias(self, func);

4
crates/ruff/src/rules/pyupgrade/rules/type_of_primitive.rs
View File

@ -27,12 +27,12 @@ impl AlwaysAutofixableViolation for TypeOfPrimitive {
} }
/// UP003 /// UP003
pub fn type_of_primitive(checker: &mut Checker, expr: &Expr, func: &Expr, args: &[Expr]) { pub fn type_of_primitive(checker: &mut Checker, expr: &Expr, args: &[Expr]) {
if args.len() != 1 { if args.len() != 1 {
return; return;
} }
if !checker if !checker
.resolve_call_path(func) .resolve_call_path(expr)
.map_or(false, |call_path| call_path.as_slice() == ["", "type"]) .map_or(false, |call_path| call_path.as_slice() == ["", "type"])
{ {
return; return;