From 74d3ad6ef4ee0849270cc77005cb4df86ee61e96 Mon Sep 17 00:00:00 2001
From: Shunsuke Shibayama <sbym1346@gmail.com>
Date: Fri, 12 Dec 2025 15:23:47 +0900
Subject: [PATCH] experiment: sort unions in cycle recovery functions

---
 crates/ty_python_semantic/src/types.rs         | 2 +-
 crates/ty_python_semantic/src/types/builder.rs | 9 +--------
 2 files changed, 2 insertions(+), 9 deletions(-)

diff --git a/crates/ty_python_semantic/src/types.rs b/crates/ty_python_semantic/src/types.rs
index 94c8d0b47d..c5392fccdd 100644
--- a/crates/ty_python_semantic/src/types.rs
+++ b/crates/ty_python_semantic/src/types.rs
@@ -14194,7 +14194,7 @@ impl<'db> UnionType<'db> {
         nested: bool,
     ) -> Option<Type<'db>> {
         let mut builder = UnionBuilder::new(db)
-            .order_elements(false)
+            .order_elements(true)
             .unpack_aliases(false)
             .cycle_recovery(true)
             .recursively_defined(self.recursively_defined(db));
diff --git a/crates/ty_python_semantic/src/types/builder.rs b/crates/ty_python_semantic/src/types/builder.rs
index 26de65a12a..21aa447b26 100644
--- a/crates/ty_python_semantic/src/types/builder.rs
+++ b/crates/ty_python_semantic/src/types/builder.rs
@@ -38,7 +38,6 @@
 //! unnecessary `is_subtype_of` checks.
 
 use crate::types::enums::{enum_member_literals, enum_metadata};
-use crate::types::type_ordering::union_or_intersection_elements_ordering;
 use crate::types::{
     BytesLiteralType, IntersectionType, KnownClass, StringLiteralType, Type,
     TypeVarBoundOrConstraints, UnionType, structural_type_ordering,
@@ -652,13 +651,7 @@ impl<'db> UnionBuilder<'db> {
             }
         }
         if self.order_elements {
-            types.sort_unstable_by(|l, r| {
-                if self.recursively_defined.is_yes() {
-                    structural_type_ordering(self.db, l, r)
-                } else {
-                    union_or_intersection_elements_ordering(self.db, l, r)
-                }
-            });
+            types.sort_unstable_by(|l, r| structural_type_ordering(self.db, l, r));
         }
         match types.len() {
             0 => None,