From 75553ab1c04fdfae4090912fcf97d12c355630fa Mon Sep 17 00:00:00 2001 From: Charlie Marsh Date: Tue, 6 Feb 2024 06:45:13 -0800 Subject: [PATCH] Remove ecosystem failures (#9854) ## Summary These are kinda disruptive, I'd prefer to TODO unless someone is interested in solving them ASAP. --- .../ruff-ecosystem/ruff_ecosystem/defaults.py | 32 ++++++++++++------- 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/python/ruff-ecosystem/ruff_ecosystem/defaults.py b/python/ruff-ecosystem/ruff_ecosystem/defaults.py index 9f4ccc4ea0..32fbd9af40 100644 --- a/python/ruff-ecosystem/ruff_ecosystem/defaults.py +++ b/python/ruff-ecosystem/ruff_ecosystem/defaults.py @@ -77,17 +77,19 @@ DEFAULT_TARGETS = [ Project( repo=Repository(owner="scikit-build", name="scikit-build-core", ref="main") ), - Project( - repo=Repository( - owner="sphinx-doc", - name="sphinx", - ref="master", - ), - format_options=FormatOptions( - # Does not contain valid UTF-8 - exclude="tests/roots/test-pycode/cp_1251_coded.py" - ), - ), + # TODO(charlie): Ecosystem check fails in non-preview due to the direct + # selection of preview rules. + # Project( + # repo=Repository( + # owner="sphinx-doc", + # name="sphinx", + # ref="master", + # ), + # format_options=FormatOptions( + # # Does not contain valid UTF-8 + # exclude="tests/roots/test-pycode/cp_1251_coded.py" + # ), + # ), Project(repo=Repository(owner="spruceid", name="siwe-py", ref="main")), Project(repo=Repository(owner="tiangolo", name="fastapi", ref="master")), Project(repo=Repository(owner="yandex", name="ch-backup", ref="main")), @@ -112,6 +114,12 @@ DEFAULT_TARGETS = [ Project( repo=Repository(owner="openai", name="openai-cookbook", ref="main"), check_options=CheckOptions(select=JUPYTER_NOTEBOOK_SELECT), - config_overrides={"include": ["*.ipynb"]}, + config_overrides={ + "include": ["*.ipynb"], + # TODO(charlie): Re-enable after fixing typo. + "exclude": [ + "examples/dalle/Image_generations_edits_and_variations_with_DALL-E.ipynb" + ], + }, ), ]