From 782cbe2e6cefe89948d9760061cea681edd6a11e Mon Sep 17 00:00:00 2001 From: weartist Date: Sun, 20 Apr 2025 16:32:09 +0800 Subject: [PATCH 1/2] add fix safety section to docs --- .../src/rules/flake8_tidy_imports/rules/relative_imports.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/crates/ruff_linter/src/rules/flake8_tidy_imports/rules/relative_imports.rs b/crates/ruff_linter/src/rules/flake8_tidy_imports/rules/relative_imports.rs index 011678ee11..c026747aea 100644 --- a/crates/ruff_linter/src/rules/flake8_tidy_imports/rules/relative_imports.rs +++ b/crates/ruff_linter/src/rules/flake8_tidy_imports/rules/relative_imports.rs @@ -44,6 +44,11 @@ use crate::rules::flake8_tidy_imports::settings::Strictness; /// ## Options /// - `lint.flake8-tidy-imports.ban-relative-imports` /// +/// ## Fix safety +/// This rule's fix is marked as unsafe because it may remove comments associated +/// with the import statement. The fix is only applied when the absolute module +/// path can be reliably determined. +/// /// [PEP 8]: https://peps.python.org/pep-0008/#imports #[derive(ViolationMetadata)] pub(crate) struct RelativeImports { From 111faccc4b3c6c2a3bbb436c6a9003be6b838213 Mon Sep 17 00:00:00 2001 From: weartist Date: Mon, 21 Apr 2025 23:02:31 +0800 Subject: [PATCH 2/2] adjust doc --- .../src/rules/flake8_tidy_imports/rules/relative_imports.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/ruff_linter/src/rules/flake8_tidy_imports/rules/relative_imports.rs b/crates/ruff_linter/src/rules/flake8_tidy_imports/rules/relative_imports.rs index c026747aea..9959196125 100644 --- a/crates/ruff_linter/src/rules/flake8_tidy_imports/rules/relative_imports.rs +++ b/crates/ruff_linter/src/rules/flake8_tidy_imports/rules/relative_imports.rs @@ -45,7 +45,7 @@ use crate::rules::flake8_tidy_imports::settings::Strictness; /// - `lint.flake8-tidy-imports.ban-relative-imports` /// /// ## Fix safety -/// This rule's fix is marked as unsafe because it may remove comments associated +/// This fix is marked as unsafe if it may remove comments associated /// with the import statement. The fix is only applied when the absolute module /// path can be reliably determined. ///