From 7d642e64169d90a3338e7ac05a0eb235b8552a27 Mon Sep 17 00:00:00 2001 From: David Peter Date: Tue, 8 Jul 2025 14:23:50 +0200 Subject: [PATCH] Add test for 'Final'-qualified field without a default --- .../resources/mdtest/dataclasses/dataclasses.md | 5 +++-- .../resources/mdtest/type_qualifiers/final.md | 4 ++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/crates/ty_python_semantic/resources/mdtest/dataclasses/dataclasses.md b/crates/ty_python_semantic/resources/mdtest/dataclasses/dataclasses.md index 814be60a1c..85305c886f 100644 --- a/crates/ty_python_semantic/resources/mdtest/dataclasses/dataclasses.md +++ b/crates/ty_python_semantic/resources/mdtest/dataclasses/dataclasses.md @@ -456,13 +456,14 @@ from typing import Final, ClassVar @dataclass class C: + instance_variable_no_default: Final[int] instance_variable: Final[int] = 1 class_variable1: ClassVar[Final[int]] = 1 class_variable2: ClassVar[Final[int]] = 1 -reveal_type(C.__init__) # revealed: (self: C, instance_variable: int = Literal[1]) -> None +reveal_type(C.__init__) # revealed: (self: C, instance_variable_no_default: int, instance_variable: int = Literal[1]) -> None -c = C() +c = C(1) # TODO: this should be an error c.instance_variable = 2 ``` diff --git a/crates/ty_python_semantic/resources/mdtest/type_qualifiers/final.md b/crates/ty_python_semantic/resources/mdtest/type_qualifiers/final.md index da1398b1ab..224115f942 100644 --- a/crates/ty_python_semantic/resources/mdtest/type_qualifiers/final.md +++ b/crates/ty_python_semantic/resources/mdtest/type_qualifiers/final.md @@ -162,6 +162,10 @@ from typing import Final # TODO: This should be an error NO_RHS: Final + +class C: + # TODO: This should be an error + NO_RHS: Final ``` [`typing.final`]: https://docs.python.org/3/library/typing.html#typing.Final