Use complete symbol for `import from` (#35)

src/check_ast.rs

@@ -28,7 +28,7 @@ enum BindingKind {
     ClassDefinition,
     Definition,
     FutureImportation,
-    Importation,
+    Importation(String),
     StarImportation,
     SubmoduleImportation,
 }
@@ -121,7 +121,13 @@ impl Visitor for Checker<'_> {
                         })
                     } else {
                         self.add_binding(Binding {
-                            kind: BindingKind::Importation,
+                            kind: BindingKind::Importation(
+                                alias
+                                    .node
+                                    .asname
+                                    .clone()
+                                    .unwrap_or_else(|| alias.node.name.clone()),
+                            ),
                             name: alias
                                 .node
                                 .asname
@@ -171,11 +177,14 @@ impl Visitor for Checker<'_> {
                         }
                     } else {
                         self.add_binding(Binding {
-                            kind: BindingKind::Importation,
+                            kind: BindingKind::Importation(match module {
+                                None => name.clone(),
+                                Some(parent) => format!("{}.{}", parent, name),
+                            }),
                             name,
                             used: false,
                             location: stmt.location,
-                        });
+                        })
                     }
                 }
             }
@@ -406,8 +415,9 @@ impl Checker<'_> {
     fn check_dead_scopes(&mut self) {
         // TODO(charlie): Handle `__all__`.
         for scope in &self.dead_scopes {
-            for (name, binding) in scope.values.iter().rev() {
+            for (_, binding) in scope.values.iter().rev() {
-                if !binding.used && matches!(binding.kind, BindingKind::Importation) {
+                if !binding.used {
+                    if let BindingKind::Importation(name) = &binding.kind {
                         self.checks.push(Check {
                             kind: CheckKind::UnusedImport(name.clone()),
                             location: binding.location,
@@ -417,6 +427,7 @@ impl Checker<'_> {
             }
         }
     }
+}
 
 pub fn check_ast(python_ast: &Suite, settings: &Settings) -> Vec<Check> {
     let mut checker = Checker::new(settings);

src/linter.rs

@@ -113,7 +113,7 @@ mod tests {
                 filename: "./resources/test/src/F401.py".to_string(),
             },
             Message {
-                kind: CheckKind::UnusedImport("OrderedDict".to_string()),
+                kind: CheckKind::UnusedImport("collections.OrderedDict".to_string()),
                 location: Location::new(3, 1),
                 filename: "./resources/test/src/F401.py".to_string(),
             },