From 85bdb45ecaa2104c40bd9b4e316cc8838405adbc Mon Sep 17 00:00:00 2001 From: Tom Fryers <61272761+TomFryers@users.noreply.github.com> Date: Sun, 15 Jan 2023 17:53:02 +0000 Subject: [PATCH] Improve magic value message wording (#1892) The message previously specified 'number', but the error applies to more types. --- README.md | 2 +- src/violations.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 7463f81976..57845ce3a1 100644 --- a/README.md +++ b/README.md @@ -1111,7 +1111,7 @@ For more, see [Pylint](https://pypi.org/project/pylint/2.15.7/) on PyPI. | PLR0402 | ConsiderUsingFromImport | Use `from ... import ...` in lieu of alias | | | PLR1701 | ConsiderMergingIsinstance | Merge these isinstance calls: `isinstance(..., (...))` | | | PLR1722 | UseSysExit | Use `sys.exit()` instead of `exit` | 🛠 | -| PLR2004 | MagicValueComparison | Magic number used in comparison, consider replacing magic with a constant variable | | +| PLR2004 | MagicValueComparison | Magic value used in comparison, consider replacing magic with a constant variable | | #### Warning (PLW) | Code | Name | Message | Fix | diff --git a/src/violations.rs b/src/violations.rs index a39b415106..60eae3e66e 100644 --- a/src/violations.rs +++ b/src/violations.rs @@ -1277,7 +1277,7 @@ impl Violation for MagicValueComparison { fn message(&self) -> String { let MagicValueComparison(value) = self; format!( - "Magic number used in comparison, consider replacing {value} with a constant variable" + "Magic value used in comparison, consider replacing {value} with a constant variable" ) }