From 89c1dc39f7cd47e9b8139bd3afa4574c01c60277 Mon Sep 17 00:00:00 2001 From: Tom Kuson Date: Tue, 6 Jun 2023 21:49:48 +0100 Subject: [PATCH] Tweak code --- .../rules/pylint/rules/iteration_over_set.rs | 2 +- ..._tests__PLC0208_iteration_over_set.py.snap | 66 +++++++------------ 2 files changed, 25 insertions(+), 43 deletions(-) diff --git a/crates/ruff/src/rules/pylint/rules/iteration_over_set.rs b/crates/ruff/src/rules/pylint/rules/iteration_over_set.rs index 8662defd54..a8c2c1bb58 100644 --- a/crates/ruff/src/rules/pylint/rules/iteration_over_set.rs +++ b/crates/ruff/src/rules/pylint/rules/iteration_over_set.rs @@ -38,7 +38,7 @@ impl Violation for IterationOverSet { /// PLC0208 pub(crate) fn iteration_over_set(checker: &mut Checker, expr: &Expr) { - if let Expr::Set(_) = expr { + if expr.is_set_expr() { checker .diagnostics .push(Diagnostic::new(IterationOverSet, expr.range())); diff --git a/crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC0208_iteration_over_set.py.snap b/crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC0208_iteration_over_set.py.snap index 5fa6435a0d..88c00a735f 100644 --- a/crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC0208_iteration_over_set.py.snap +++ b/crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC0208_iteration_over_set.py.snap @@ -10,62 +10,44 @@ iteration_over_set.py:3:13: PLC0208 Use a sequence type instead of a `set` when 6 | print(f"I like {item}.") | -iteration_over_set.py:6:13: PLC0208 Use a sequence type instead of a `set` when iterating over values - | -6 | print(f"I like {item}.") -7 | -8 | for item in set(("apples", "lemons", "water")): # flags set() calls - | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PLC0208 -9 | print(f"I like {item}.") - | - -iteration_over_set.py:9:15: PLC0208 Use a sequence type instead of a `set` when iterating over values +iteration_over_set.py:6:28: PLC0208 Use a sequence type instead of a `set` when iterating over values | - 9 | print(f"I like {item}.") -10 | -11 | for number in {i for i in range(10)}: # flags set comprehensions - | ^^^^^^^^^^^^^^^^^^^^^^ PLC0208 -12 | print(number) - | - -iteration_over_set.py:12:28: PLC0208 Use a sequence type instead of a `set` when iterating over values - | -12 | print(number) -13 | -14 | numbers_list = [i for i in {1, 2, 3}] # flags sets in list comprehensions + 6 | print(f"I like {item}.") + 7 | + 8 | numbers_list = [i for i in {1, 2, 3}] # flags sets in list comprehensions | ^^^^^^^^^ PLC0208 -15 | -16 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions + 9 | +10 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions | -iteration_over_set.py:14:27: PLC0208 Use a sequence type instead of a `set` when iterating over values +iteration_over_set.py:8:27: PLC0208 Use a sequence type instead of a `set` when iterating over values | -14 | numbers_list = [i for i in {1, 2, 3}] # flags sets in list comprehensions -15 | -16 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions + 8 | numbers_list = [i for i in {1, 2, 3}] # flags sets in list comprehensions + 9 | +10 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions | ^^^^^^^^^ PLC0208 -17 | -18 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions +11 | +12 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions | -iteration_over_set.py:16:36: PLC0208 Use a sequence type instead of a `set` when iterating over values +iteration_over_set.py:10:36: PLC0208 Use a sequence type instead of a `set` when iterating over values | -16 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions -17 | -18 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions +10 | numbers_set = {i for i in {1, 2, 3}} # flags sets in set comprehensions +11 | +12 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions | ^^^^^^^^^ PLC0208 -19 | -20 | numbers_gen = (i for i in {1, 2, 3}) # flags sets in generator expressions +13 | +14 | numbers_gen = (i for i in {1, 2, 3}) # flags sets in generator expressions | -iteration_over_set.py:18:27: PLC0208 Use a sequence type instead of a `set` when iterating over values +iteration_over_set.py:12:27: PLC0208 Use a sequence type instead of a `set` when iterating over values | -18 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions -19 | -20 | numbers_gen = (i for i in {1, 2, 3}) # flags sets in generator expressions +12 | numbers_dict = {str(i): i for i in {1, 2, 3}} # flags sets in dict comprehensions +13 | +14 | numbers_gen = (i for i in {1, 2, 3}) # flags sets in generator expressions | ^^^^^^^^^ PLC0208 -21 | -22 | # Non-errors +15 | +16 | # Non-errors |