Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add `sqlalchemy` methods to boolean-trap exclusion list (#7874) 

Closes https://github.com/astral-sh/ruff/issues/7869.
This commit is contained in:
Charlie Marsh 2023-10-09 14:50:51 -04:00 committed by GitHub
parent 016e16254a
commit 97e944003b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/ruff_linter/resources/test/fixtures/flake8_boolean_trap/FBT.py vendored
View File

@ -70,6 +70,8 @@ settings.set_enable_developer_extras(True)
foo.is_(True) foo.is_(True)
bar.is_not(False) bar.is_not(False)
next(iter([]), False) next(iter([]), False)
sa.func.coalesce(tbl.c.valid, False)
class Registry: class Registry:
def __init__(self) -> None: def __init__(self) -> None:

4
crates/ruff_linter/src/rules/flake8_boolean_trap/helpers.rs
View File

@ -12,6 +12,7 @@ pub(super) fn is_allowed_func_call(name: &str) -> bool {
| "assertNotEquals" | "assertNotEquals"
| "bool" | "bool"
| "bytes" | "bytes"
// | "coalesce"
| "count" | "count"
| "failIfEqual" | "failIfEqual"
| "failUnlessEqual" | "failUnlessEqual"
@ -22,12 +23,15 @@ pub(super) fn is_allowed_func_call(name: &str) -> bool {
| "getboolean" | "getboolean"
| "getfloat" | "getfloat"
| "getint" | "getint"
| "ifnull"
| "index" | "index"
| "insert" | "insert"
| "int" | "int"
| "is_" | "is_"
| "is_not" | "is_not"
| "isnull"
| "next" | "next"
| "nvl"
| "param" | "param"
| "pop" | "pop"
| "remove" | "remove"

8
crates/ruff_linter/src/rules/flake8_boolean_trap/snapshots/ruff_linter__rules__flake8_boolean_trap__tests__FBT001_FBT.py.snap
View File

@ -81,12 +81,12 @@ FBT.py:19:5: FBT001 Boolean-typed positional argument in function definition
21 | kwonly_nonvalued_nohint, 21 | kwonly_nonvalued_nohint,
| |
FBT.py:87:19: FBT001 Boolean-typed positional argument in function definition FBT.py:89:19: FBT001 Boolean-typed positional argument in function definition
| |
86 | # FBT001: Boolean positional arg in function definition 88 | # FBT001: Boolean positional arg in function definition
87 | def foo(self, value: bool) -> None: 89 | def foo(self, value: bool) -> None:
| ^^^^^ FBT001 | ^^^^^ FBT001
88 | pass 90 | pass
| |

8
crates/ruff_linter/src/rules/flake8_boolean_trap/snapshots/ruff_linter__rules__flake8_boolean_trap__tests__FBT003_FBT.py.snap
View File

@ -38,4 +38,12 @@ FBT.py:69:38: FBT003 Boolean positional value in function call
71 | bar.is_not(False) 71 | bar.is_not(False)
| |
FBT.py:73:31: FBT003 Boolean positional value in function call
|
71 | bar.is_not(False)
72 | next(iter([]), False)
73 | sa.func.coalesce(tbl.c.valid, False)
| ^^^^^ FBT003
|