mirror of https://github.com/astral-sh/ruff
Move rule code from `description` to `check_name` in GitLab output serializer (#16437)
This commit is contained in:
parent
0c7c001647
commit
980faff176
|
|
@ -90,13 +90,22 @@ impl Serialize for SerializedMessages<'_> {
|
||||||
}
|
}
|
||||||
fingerprints.insert(message_fingerprint);
|
fingerprints.insert(message_fingerprint);
|
||||||
|
|
||||||
let description = if let Some(rule) = message.rule() {
|
let (description, check_name) = if let Some(rule) = message.rule() {
|
||||||
format!("({}) {}", rule.noqa_code(), message.body())
|
(message.body().to_string(), rule.noqa_code().to_string())
|
||||||
} else {
|
} else {
|
||||||
message.body().to_string()
|
let description = message.body();
|
||||||
|
let description_without_prefix = description
|
||||||
|
.strip_prefix("SyntaxError: ")
|
||||||
|
.unwrap_or(description);
|
||||||
|
|
||||||
|
(
|
||||||
|
description_without_prefix.to_string(),
|
||||||
|
"syntax-error".to_string(),
|
||||||
|
)
|
||||||
};
|
};
|
||||||
|
|
||||||
let value = json!({
|
let value = json!({
|
||||||
|
"check_name": check_name,
|
||||||
"description": description,
|
"description": description,
|
||||||
"severity": "major",
|
"severity": "major",
|
||||||
"fingerprint": format!("{:x}", message_fingerprint),
|
"fingerprint": format!("{:x}", message_fingerprint),
|
||||||
|
|
|
||||||
|
|
@ -1,11 +1,11 @@
|
||||||
---
|
---
|
||||||
source: crates/ruff_linter/src/message/gitlab.rs
|
source: crates/ruff_linter/src/message/gitlab.rs
|
||||||
expression: redact_fingerprint(&content)
|
expression: redact_fingerprint(&content)
|
||||||
snapshot_kind: text
|
|
||||||
---
|
---
|
||||||
[
|
[
|
||||||
{
|
{
|
||||||
"description": "(F401) `os` imported but unused",
|
"check_name": "F401",
|
||||||
|
"description": "`os` imported but unused",
|
||||||
"fingerprint": "<redacted>",
|
"fingerprint": "<redacted>",
|
||||||
"location": {
|
"location": {
|
||||||
"lines": {
|
"lines": {
|
||||||
|
|
@ -17,7 +17,8 @@ snapshot_kind: text
|
||||||
"severity": "major"
|
"severity": "major"
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"description": "(F841) Local variable `x` is assigned to but never used",
|
"check_name": "F841",
|
||||||
|
"description": "Local variable `x` is assigned to but never used",
|
||||||
"fingerprint": "<redacted>",
|
"fingerprint": "<redacted>",
|
||||||
"location": {
|
"location": {
|
||||||
"lines": {
|
"lines": {
|
||||||
|
|
@ -29,7 +30,8 @@ snapshot_kind: text
|
||||||
"severity": "major"
|
"severity": "major"
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"description": "(F821) Undefined name `a`",
|
"check_name": "F821",
|
||||||
|
"description": "Undefined name `a`",
|
||||||
"fingerprint": "<redacted>",
|
"fingerprint": "<redacted>",
|
||||||
"location": {
|
"location": {
|
||||||
"lines": {
|
"lines": {
|
||||||
|
|
|
||||||
|
|
@ -1,11 +1,11 @@
|
||||||
---
|
---
|
||||||
source: crates/ruff_linter/src/message/gitlab.rs
|
source: crates/ruff_linter/src/message/gitlab.rs
|
||||||
expression: redact_fingerprint(&content)
|
expression: redact_fingerprint(&content)
|
||||||
snapshot_kind: text
|
|
||||||
---
|
---
|
||||||
[
|
[
|
||||||
{
|
{
|
||||||
"description": "SyntaxError: Expected one or more symbol names after import",
|
"check_name": "syntax-error",
|
||||||
|
"description": "Expected one or more symbol names after import",
|
||||||
"fingerprint": "<redacted>",
|
"fingerprint": "<redacted>",
|
||||||
"location": {
|
"location": {
|
||||||
"lines": {
|
"lines": {
|
||||||
|
|
@ -17,7 +17,8 @@ snapshot_kind: text
|
||||||
"severity": "major"
|
"severity": "major"
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"description": "SyntaxError: Expected ')', found newline",
|
"check_name": "syntax-error",
|
||||||
|
"description": "Expected ')', found newline",
|
||||||
"fingerprint": "<redacted>",
|
"fingerprint": "<redacted>",
|
||||||
"location": {
|
"location": {
|
||||||
"lines": {
|
"lines": {
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue