mirror of https://github.com/astral-sh/ruff
Don't install Rust before running pre-commit in CI (#17050)
Following29573daef5, it doesn't look to me like any of the pre-commit hooks run in CI here are Rust-based: - `cargo fmt` is Rust-based but it's explicitly skipped as part of this job and run as a separate CI job:93052331b0/.pre-commit-config.yaml (L124-L125)- The `typos` hook is Rust-based, but according to https://github.com/crate-ci/typos/blob/master/docs/pre-commit.md pre-commit should install a built binary rather than building the binary from source As such, I think this step in the workflow is just taking up 15s of CI time and not actually speeding up pre-commit at all
This commit is contained in:
parent
93052331b0
commit
98438a77f2
|
|
@ -651,9 +651,6 @@ jobs:
|
|||
- uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5
|
||||
with:
|
||||
python-version: ${{ env.PYTHON_VERSION }}
|
||||
- uses: Swatinem/rust-cache@9d47c6ad4b02e050fd481d890b2ea34778fd09d6 # v2
|
||||
- name: "Install Rust toolchain"
|
||||
run: rustup show
|
||||
- name: "Install pre-commit"
|
||||
run: pip install pre-commit
|
||||
- name: "Cache pre-commit"
|
||||
|
|
|
|||
Loading…
Reference in New Issue