Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Detect multi-target assignment as unpacking if *any* target is unpacking (#217)

This commit is contained in:
Anders Kaseorg 2022-09-16 20:45:44 -07:00 committed by GitHub
parent edecc1bba6
commit 9bdb922c75
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
resources/test/fixtures/F841.py vendored
View File

@ -22,3 +22,5 @@ def g():
bar = (1, 2) bar = (1, 2)
(c, d) = bar (c, d) = bar
(x, y) = baz = bar

12
src/ast/operations.rs
View File

@ -101,11 +101,13 @@ pub fn in_nested_block(parent_stack: &[usize], parents: &[&Stmt]) -> bool {
/// Check if a node represents an unpacking assignment. /// Check if a node represents an unpacking assignment.
pub fn is_unpacking_assignment(stmt: &Stmt) -> bool { pub fn is_unpacking_assignment(stmt: &Stmt) -> bool {
if let StmtKind::Assign { targets, value, .. } = &stmt.node { if let StmtKind::Assign { targets, value, .. } = &stmt.node {
for child in targets { if !targets.iter().any(|child| {
match &child.node { matches!(
ExprKind::Set { .. } | ExprKind::List { .. } | ExprKind::Tuple { .. } => {} child.node,
_ => return false, ExprKind::Set { .. } | ExprKind::List { .. } | ExprKind::Tuple { .. }
} )
}) {
return false;
} }
match &value.node { match &value.node {
ExprKind::Set { .. } | ExprKind::List { .. } | ExprKind::Tuple { .. } => return false, ExprKind::Set { .. } | ExprKind::List { .. } | ExprKind::Tuple { .. } => return false,