Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Respect `per-file-ignores` for `RUF100` on blanket `# noqa` (#10908) 

## Summary

If `RUF100` was included in a per-file-ignore, we respected it on cases
like `# noqa: F401`, but not the blanket variant (`# noqa`).

Closes https://github.com/astral-sh/ruff/issues/10906.
This commit is contained in:
Charlie Marsh 2024-04-12 09:45:29 -04:00 committed by GitHub
parent 2e37cf6b3b
commit a013050c11
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
crates/ruff_linter/resources/test/fixtures/ruff/ruff_per_file_ignores.py vendored
View File

@ -1,2 +1,3 @@
import os
import foo # noqa: F401
import bar # noqa

3
crates/ruff_linter/src/checkers/noqa.rs
View File

@ -111,6 +111,7 @@ pub(crate) fn check_noqa(
FileExemption::All => true,
FileExemption::Codes(codes) => codes.contains(&Rule::UnusedNOQA.noqa_code()),
})
&& !per_file_ignores.contains(Rule::UnusedNOQA)
{
for line in noqa_directives.lines() {
match &line.directive {
@ -129,7 +130,7 @@ pub(crate) fn check_noqa(
let mut unknown_codes = vec![];
let mut unmatched_codes = vec![];
let mut valid_codes = vec![];
let mut self_ignore = per_file_ignores.contains(Rule::UnusedNOQA);
let mut self_ignore = false;
for code in directive.codes() {
let code = get_redirect_target(code).unwrap_or(code);
if Rule::UnusedNOQA.noqa_code() == code {