Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-23 06:20:55 -05:00
Code Issues Packages Projects Releases Wiki Activity

Visit NamedExpr values before targets (#2484)

Browse Source
This commit is contained in:
Charlie Marsh
2023-02-02 12:21:58 -05:00
committed by GitHub
parent ac41c33d1f
commit a0df78cb7d
3 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ast/visitor.rs
View File

@@ -266,8 +266,8 @@ pub fn walk_expr<'a, V: Visitor<'a> + ?Sized>(visitor: &mut V, expr: &'a Expr) {
}
}
ExprKind::NamedExpr { target, value } => {
visitor.visit_expr(target);
visitor.visit_expr(value);
visitor.visit_expr(target);
}
ExprKind::BinOp { left, op, right } => {
visitor.visit_expr(left);

2
src/checkers/ast.rs
View File

@@ -4449,7 +4449,7 @@ impl<'a> Checker<'a> {
fn check_deferred_assignments(&mut self) {
self.deferred_assignments.reverse();
while let Some((scopes, _parents)) = self.deferred_assignments.pop() {
while let Some((scopes, ..)) = self.deferred_assignments.pop() {
let scope_index = scopes[scopes.len() - 1];
let parent_scope_index = scopes[scopes.len() - 2];
if self.settings.rules.enabled(&Rule::UnusedVariable) {