Python/ruff
1
0
Fork 0
mirror of https://github.com/astral-sh/ruff synced 2026-01-07 14:44:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Use correct start location for class/function clause header (#7802)

Browse Source 
## Summary

This PR fixes the bug where the formatter would panic if a class/function with
decorators had a suppression comment.

The fix is to use to correct start location to find the `async`/`def`/`class`
keyword when decorators are present which is the end of the last
decorator.

## Test Plan

Add test cases for the fix and update the snapshots.
This commit is contained in:
Dhruv Manilawala
2023-10-04 13:25:01 +05:30
committed by GitHub
parent 7b4fb4fb5d
commit a1509dfc7c
3 changed files with 50 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
crates/ruff_python_formatter/tests/snapshots/format@fmt_skip__decorators.py.snap
View File

@@ -23,6 +23,19 @@ class Test:
def test():
pass
# Regression test for https://github.com/astral-sh/ruff/issues/7735
@decorator1
@decorator2
class Foo: # fmt: skip
pass
# Regression test for https://github.com/astral-sh/ruff/issues/7735
@decorator1
@decorator2
def foo(): # fmt: skip
pass
```
## Output
@@ -43,6 +56,20 @@ class Test:
# leading class comment
def test():
pass
# Regression test for https://github.com/astral-sh/ruff/issues/7735
@decorator1
@decorator2
class Foo: # fmt: skip
pass
# Regression test for https://github.com/astral-sh/ruff/issues/7735
@decorator1
@decorator2
def foo(): # fmt: skip
pass
```