From a3b4adab3f28461e419605059a992ff4ba1452b9 Mon Sep 17 00:00:00 2001 From: Dhruv Manilawala Date: Thu, 13 Jul 2023 20:55:15 +0530 Subject: [PATCH] Update w.r.t latest API changes --- .../src/rules/pyflakes/rules/unused_import.rs | 4 +- ...les__pyflakes__tests__F401_F401_20.py.snap | 54 +++++++++++++++++++ 2 files changed, 56 insertions(+), 2 deletions(-) create mode 100644 crates/ruff/src/rules/pyflakes/snapshots/ruff__rules__pyflakes__tests__F401_F401_20.py.snap diff --git a/crates/ruff/src/rules/pyflakes/rules/unused_import.rs b/crates/ruff/src/rules/pyflakes/rules/unused_import.rs index 540197ab38..74acd89f29 100644 --- a/crates/ruff/src/rules/pyflakes/rules/unused_import.rs +++ b/crates/ruff/src/rules/pyflakes/rules/unused_import.rs @@ -116,8 +116,8 @@ pub(crate) fn unused_import(checker: &Checker, scope: &Scope, diagnostics: &mut }; for binding in scope - .bindings_for_name(binding_name) - .map(|binding_id| &checker.semantic_model().bindings[binding_id]) + .get_all(binding_name) + .map(|binding_id| checker.semantic().binding(binding_id)) { let Some(qualified_name) = binding.qualified_name() else { break; diff --git a/crates/ruff/src/rules/pyflakes/snapshots/ruff__rules__pyflakes__tests__F401_F401_20.py.snap b/crates/ruff/src/rules/pyflakes/snapshots/ruff__rules__pyflakes__tests__F401_F401_20.py.snap new file mode 100644 index 0000000000..3d62efc6e6 --- /dev/null +++ b/crates/ruff/src/rules/pyflakes/snapshots/ruff__rules__pyflakes__tests__F401_F401_20.py.snap @@ -0,0 +1,54 @@ +--- +source: crates/ruff/src/rules/pyflakes/mod.rs +--- +F401_20.py:7:8: F401 [*] `multiprocessing.connection` imported but unused + | +5 | multiprocessing = None +6 | +7 | import multiprocessing.connection + | ^^^^^^^^^^^^^^^^^^^^^^^^^^ F401 +8 | import multiprocessing.pool +9 | import multiprocessing.queues + | + = help: Remove unused import: `multiprocessing.connection` + +ℹ Fix +4 4 | # imports. It should only detect imports, not any other kind of binding. +5 5 | multiprocessing = None +6 6 | +7 |-import multiprocessing.connection +8 7 | import multiprocessing.pool +9 8 | import multiprocessing.queues + +F401_20.py:8:8: F401 [*] `multiprocessing.pool` imported but unused + | +7 | import multiprocessing.connection +8 | import multiprocessing.pool + | ^^^^^^^^^^^^^^^^^^^^ F401 +9 | import multiprocessing.queues + | + = help: Remove unused import: `multiprocessing.pool` + +ℹ Fix +5 5 | multiprocessing = None +6 6 | +7 7 | import multiprocessing.connection +8 |-import multiprocessing.pool +9 8 | import multiprocessing.queues + +F401_20.py:9:8: F401 [*] `multiprocessing.queues` imported but unused + | +7 | import multiprocessing.connection +8 | import multiprocessing.pool +9 | import multiprocessing.queues + | ^^^^^^^^^^^^^^^^^^^^^^ F401 + | + = help: Remove unused import: `multiprocessing.queues` + +ℹ Fix +6 6 | +7 7 | import multiprocessing.connection +8 8 | import multiprocessing.pool +9 |-import multiprocessing.queues + +