From a82fe4a1397a1e271ead3b7662df0d467f7f4ba3 Mon Sep 17 00:00:00 2001 From: Grzegorz Bokota Date: Tue, 14 Mar 2023 00:19:41 +0100 Subject: [PATCH] Fix lack of `not` in `PLC1901` error message (#3497) --- .../src/rules/pylint/rules/compare_to_empty_string.rs | 4 ++-- ...int__tests__PLC1901_compare_to_empty_string.py.snap | 10 +++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/crates/ruff/src/rules/pylint/rules/compare_to_empty_string.rs b/crates/ruff/src/rules/pylint/rules/compare_to_empty_string.rs index d287074298..06e23b065f 100644 --- a/crates/ruff/src/rules/pylint/rules/compare_to_empty_string.rs +++ b/crates/ruff/src/rules/pylint/rules/compare_to_empty_string.rs @@ -34,8 +34,8 @@ impl TryFrom<&Cmpop> for EmptyStringCmpop { impl EmptyStringCmpop { pub fn into_unary(self) -> &'static str { match self { - Self::Is | Self::Eq => "", - Self::IsNot | Self::NotEq => "not ", + Self::Is | Self::Eq => "not ", + Self::IsNot | Self::NotEq => "", } } } diff --git a/crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC1901_compare_to_empty_string.py.snap b/crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC1901_compare_to_empty_string.py.snap index d26a45408f..22a19ceab5 100644 --- a/crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC1901_compare_to_empty_string.py.snap +++ b/crates/ruff/src/rules/pylint/snapshots/ruff__rules__pylint__tests__PLC1901_compare_to_empty_string.py.snap @@ -4,7 +4,7 @@ expression: diagnostics --- - kind: name: CompareToEmptyString - body: "`x is \"\"` can be simplified to `x` as an empty string is falsey" + body: "`x is \"\"` can be simplified to `not x` as an empty string is falsey" suggestion: ~ fixable: false location: @@ -17,7 +17,7 @@ expression: diagnostics parent: ~ - kind: name: CompareToEmptyString - body: "`x == \"\"` can be simplified to `x` as an empty string is falsey" + body: "`x == \"\"` can be simplified to `not x` as an empty string is falsey" suggestion: ~ fixable: false location: @@ -30,7 +30,7 @@ expression: diagnostics parent: ~ - kind: name: CompareToEmptyString - body: "`y is not \"\"` can be simplified to `not y` as an empty string is falsey" + body: "`y is not \"\"` can be simplified to `y` as an empty string is falsey" suggestion: ~ fixable: false location: @@ -43,7 +43,7 @@ expression: diagnostics parent: ~ - kind: name: CompareToEmptyString - body: "`y != \"\"` can be simplified to `not y` as an empty string is falsey" + body: "`y != \"\"` can be simplified to `y` as an empty string is falsey" suggestion: ~ fixable: false location: @@ -56,7 +56,7 @@ expression: diagnostics parent: ~ - kind: name: CompareToEmptyString - body: "`\"\" != z` can be simplified to `not z` as an empty string is falsey" + body: "`\"\" != z` can be simplified to `z` as an empty string is falsey" suggestion: ~ fixable: false location: