mirror of
https://github.com/astral-sh/ruff
synced 2026-01-08 15:14:19 -05:00
Create snake_case file if linter is Pylint (#5948)
## Summary The `add_rule.py` script would create a test case that pointed to a file that didn't exist when the linter is set to `"pylint"`. This PR fixes that. ## Test Plan `python scripts/add_rule.py --name DoTheThing --prefix PL --code C0999 --linter pylint`
This commit is contained in:
@@ -20,11 +20,12 @@ from _utils import ROOT_DIR, dir_name, get_indent, pascal_case, snake_case
|
||||
def main(*, name: str, prefix: str, code: str, linter: str) -> None:
|
||||
"""Generate boilerplate for a new rule."""
|
||||
# Create a test fixture.
|
||||
filestem = f"{prefix}{code}" if linter != "pylint" else snake_case(name)
|
||||
with (
|
||||
ROOT_DIR
|
||||
/ "crates/ruff/resources/test/fixtures"
|
||||
/ dir_name(linter)
|
||||
/ f"{prefix}{code}.py"
|
||||
/ f"{filestem}.py"
|
||||
).open(
|
||||
"a",
|
||||
):
|
||||
@@ -45,7 +46,6 @@ def main(*, name: str, prefix: str, code: str, linter: str) -> None:
|
||||
line.strip() == "fn rules(rule_code: Rule, path: &Path) -> Result<()> {"
|
||||
):
|
||||
indent = get_indent(line)
|
||||
filestem = f"{prefix}{code}" if linter != "pylint" else snake_case(name)
|
||||
lines.append(
|
||||
f'{indent}#[test_case(Rule::{name}, Path::new("{filestem}.py"))]',
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user