Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Create snake_case file if linter is Pylint (#5948) 

## Summary

The `add_rule.py` script would create a test case that pointed to a file
that didn't exist when the linter is set to `"pylint"`. This PR fixes
that.

## Test Plan

`python scripts/add_rule.py --name DoTheThing --prefix PL --code C0999
--linter pylint`
This commit is contained in:
Tom Kuson 2023-07-22 03:13:43 +01:00 committed by GitHub
parent 2dcd9e2e9c
commit aaf7f362a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
scripts/add_rule.py
View File

@ -20,11 +20,12 @@ from _utils import ROOT_DIR, dir_name, get_indent, pascal_case, snake_case
def main(*, name: str, prefix: str, code: str, linter: str) -> None: def main(*, name: str, prefix: str, code: str, linter: str) -> None:
"""Generate boilerplate for a new rule.""" """Generate boilerplate for a new rule."""
# Create a test fixture. # Create a test fixture.
filestem = f"{prefix}{code}" if linter != "pylint" else snake_case(name)
with ( with (
ROOT_DIR ROOT_DIR
/ "crates/ruff/resources/test/fixtures" / "crates/ruff/resources/test/fixtures"
/ dir_name(linter) / dir_name(linter)
/ f"{prefix}{code}.py" / f"{filestem}.py"
).open( ).open(
"a", "a",
): ):
@ -45,7 +46,6 @@ def main(*, name: str, prefix: str, code: str, linter: str) -> None:
line.strip() == "fn rules(rule_code: Rule, path: &Path) -> Result<()> {" line.strip() == "fn rules(rule_code: Rule, path: &Path) -> Result<()> {"
): ):
indent = get_indent(line) indent = get_indent(line)
filestem = f"{prefix}{code}" if linter != "pylint" else snake_case(name)
lines.append( lines.append(
f'{indent}#[test_case(Rule::{name}, Path::new("{filestem}.py"))]', f'{indent}#[test_case(Rule::{name}, Path::new("{filestem}.py"))]',
) )