From af4cb34ce2a33c2ab8983eedc31cc539747af8e3 Mon Sep 17 00:00:00 2001 From: Zanie Blue Date: Sun, 29 Oct 2023 00:13:28 -0500 Subject: [PATCH] Update old ecosystem checks for formatter for clarity (#8285) Changes the title and adds some notes re the old formatter ecosystem checks in light of #8223 Does not remove it as I'm not sure where else we test for instabilities. --- .github/workflows/ci.yaml | 4 ++-- scripts/formatter_ecosystem_checks.sh | 5 +++++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index effcd8b0c9..da317fcdef 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -349,8 +349,8 @@ jobs: if: ${{ env.MKDOCS_INSIDERS_SSH_KEY_EXISTS != 'true' }} run: mkdocs build --strict -f mkdocs.generated.yml - check-formatter-ecosystem: - name: "Formatter ecosystem and progress checks" + check-formatter-instability-and-black-similarity: + name: "formatter instabilities and black similarity" runs-on: ubuntu-latest needs: determine_changes if: needs.determine_changes.outputs.formatter == 'true' || github.ref == 'refs/heads/main' diff --git a/scripts/formatter_ecosystem_checks.sh b/scripts/formatter_ecosystem_checks.sh index ec8d41dcbd..7acf0974a1 100755 --- a/scripts/formatter_ecosystem_checks.sh +++ b/scripts/formatter_ecosystem_checks.sh @@ -1,4 +1,9 @@ #!/usr/bin/env bash +# **NOTE** +# This script is being replaced by the ruff-ecosystem package which is no +# longer focused on black-compatibility but on changes in formatting between +# ruff versions. ruff-ecosystem does not support instability checks yet. +# # Check black compatibility and check for formatter instabilities and other # errors. #