Python
/
ruff
mirror of https://github.com/astral-sh/ruff
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

leave some TODOs

This commit is contained in:
Aria Desires 2025-12-02 14:39:24 -05:00
parent 7ca384d0de
commit b0c31d0c59
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crates/ty_python_semantic/src/types/infer/builder.rs
View File

@ -6507,6 +6507,10 @@ impl<'db, 'ast> TypeInferenceBuilder<'db, 'ast> {
if symbol.is_bound() || symbol.is_declared() { if symbol.is_bound() || symbol.is_declared() {
// This name is explicitly defined in the global scope (not just in function // This name is explicitly defined in the global scope (not just in function
// bodies that mark it `global`). // bodies that mark it `global`).
//
// TODO: call `self.store_expression_type(name)` here with the computed type of
// the variable (requires `infer_load_name` but for `Identifier`). This would
// empower displaying the type on-hover in the LSP.
continue; continue;
} }
} }
@ -6588,6 +6592,10 @@ impl<'db, 'ast> TypeInferenceBuilder<'db, 'ast> {
// but it's ok if it's `nonlocal`. If a "chain" of `nonlocal` statements fails to // but it's ok if it's `nonlocal`. If a "chain" of `nonlocal` statements fails to
// lead to a valid binding, the outermost one will be an error; we don't need to // lead to a valid binding, the outermost one will be an error; we don't need to
// walk the whole chain for each one. // walk the whole chain for each one.
//
// TODO: call `self.store_expression_type(name)` here with the computed type of
// the variable (requires `infer_load_name` but for `Identifier`). This would
// empower displaying the type on-hover in the LSP.
continue 'names; continue 'names;
} }
// There's no matching binding in an enclosing scope. This `nonlocal` statement is // There's no matching binding in an enclosing scope. This `nonlocal` statement is